From c46f027eb0b0d8d636d34e6e01ae47d42e069911 Mon Sep 17 00:00:00 2001 From: Leo Romanovsky Date: Mon, 14 Oct 2024 21:02:48 -0700 Subject: [PATCH] bug(python): add bandit_configuration parameter to python configuration initialization (FF-3390) --- python-sdk/python/eppo_client/_eppo_client.pyi | 18 +++++++++++++++++- sdk-test-data | 2 +- 2 files changed, 18 insertions(+), 2 deletions(-) diff --git a/python-sdk/python/eppo_client/_eppo_client.pyi b/python-sdk/python/eppo_client/_eppo_client.pyi index e19aa9d6..3ee0d17d 100644 --- a/python-sdk/python/eppo_client/_eppo_client.pyi +++ b/python-sdk/python/eppo_client/_eppo_client.pyi @@ -6,7 +6,23 @@ def init(config: ClientConfig) -> EppoClient: ... def get_instance() -> EppoClient: ... class Configuration: - def __init__(self, flags_configuration: bytes) -> None: ... + # Note: Before publshing v5.0.0 + # + # Users current have to initialize the configuration like this: + # + # Configuration(some_bytes, some_other_bytes) + # + # In v5.0.0, we will add a named parameter to the constructor to make this + # more clear. + # + # Users will be able to initialize the configuration like this: + # + # Configuration(flags_configuration=some_bytes, bandits_configuration=some_other_bytes) + # + # Changes: + # + # def __init__(self, *, flags_configuration: bytes, bandits_configuration: bytes | None = None) -> None: ... + def __init__(self, flags_configuration: bytes, bandits_configuration: bytes | None = None) -> None: ... def get_flags_configuration(self) -> bytes: ... def get_flag_keys(self) -> Set[str]: ... def get_bandit_keys(self) -> Set[str]: ... diff --git a/sdk-test-data b/sdk-test-data index 580a7e3e..11dace62 160000 --- a/sdk-test-data +++ b/sdk-test-data @@ -1 +1 @@ -Subproject commit 580a7e3e05e04159a1395ec2d2107d3c83a032ec +Subproject commit 11dace62a7ce97792bd54e48aaf354f62a034d63