feat(ruby): add offline initialization and Configuration API #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rasendubi
force-pushed
the
feat-ruby-offline-init
branch
from
337d1b4 to
707bc82
Compare
rasendubi
force-pushed
the
feat-ruby-offline-init
branch
from
454df8b to
4e93251
Compare
rasendubi
force-pushed
the
feat-ruby-offline-init
branch
from
4e93251 to
3797d11
Compare
aarsilv
approved these changes
Oct 10, 2024
|
|
||
| # require 'eppo_client' | ||
|
|
||
| RSpec.describe EppoClient::Configuration do |
| end | ||
| end | ||
|
|
||
| describe "bandits_configuration()" do |
| end | ||
| end | ||
|
|
||
| it "can be reinstantiated from own configuration" do |
Comment on lines
+71
to
+72
| expect(config1.flags_configuration).to eq(config2.flags_configuration) | ||
| expect(config1.bandits_configuration).to eq(config2.bandits_configuration) |
| # guarantee. We're using it here because serialization order of | ||
| # bandits is not guaranteed. | ||
| expect(JSON.parse(config1.bandits_configuration)).to eq(JSON.parse(config2.bandits_configuration)) | ||
| end |
There was a problem hiding this comment.
I wonder if we should test what happens if it's initialized with an invalid JSON configuration (e.g., an empty file). I'm thinking we want the SDK to boot but with no pre-initialized flags, perhaps logging a warning?
There was a problem hiding this comment.
There's a test for that. It will fail to create a Configuration.
aarsilv
reviewed
Oct 11, 2024
| }.to raise_error TypeError | ||
| end | ||
|
|
||
| it "throws on parse error" do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to initialize Ruby SDK in offline mode by passing
poll_interval_seconds: niland getting/setting configuration by usingconfiguration/configuration=methods onEppoClient.