Create fastly-edge-assignments integration tests #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leoromanovsky
force-pushed
the
lr/poc-tests
branch
from
b3065f8 to
24f3e86
Compare
leoromanovsky
force-pushed
the
lr/poc-tests
branch
from
24f3e86 to
2209629
Compare
leoromanovsky
commented
Nov 25, 2024
| #[fastly::main] | ||
| fn main(req: Request) -> Result<Response, Error> { | ||
| fn main() -> Result<(), Error> { | ||
| let ds_req = Request::from_client(); |
There was a problem hiding this comment.
This is required scaffolding to run integration tests.
leoromanovsky
commented
Nov 25, 2024
| target: wasm32-wasi | ||
|
|
||
| # Install tools only if not cached | ||
| - name: Install Tools |
There was a problem hiding this comment.
this step takes ~7 min so I added it to the github cache
rasendubi
approved these changes
Dec 2, 2024
Co-authored-by: Oleksii Shmalko <[email protected]>
This reverts commit 9131130.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Observation
Moving beyond the M1 for this project to a trusted tool, we need to add integration and unit tests.
A few constraints on testability is that we are compiling a
wasmtarget and deploying to the fastly platform.The purpose of this PR is to create the scaffolding for future tests and not an exhaustive suite.
Description
For integration testing I am choosing to use the
fastlycli which comes with a rust build program; this is the same process we use for building the deployable package.Viceroy will let us locally create fastly services; we already use it for running the local environment with a pre-populated KV store entry.
cargo-nextestis a test runner recommended by fastly.I followed the fastly guides (https://www.fastly.com/blog/how-to-write-rust-unit-tests-for-your-compute-edge-application).