Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "mobs now respect armor when attacking" #58

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

valkyria-gk
Copy link

Reverts #40

Turns out that we have been looking at the wrong spot in the code. The change applies to the wrong type of mobs since human mobs have their own damage-handling process at:

/mob/living/carbon/human/attack_generic(mob/user, damage, attack_message, damagetype = BRUTE, attack_flag = ARMOR_MELEE, sharp = FALSE, edge = FALSE)

So far it has been a travesty. We had been too confident in the change. This revert means we should go look at other options of the armour issue instead. Look at other problems that more worth investigating.

Changelog

🆑
fix: Reverted a change to how simple mobs are damaged.
/:cl:

Copy link

@Takykardi Takykardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple revert PR, ready to go in case it's still needed.

@valkyria-gk valkyria-gk merged commit 4e907a2 into master Sep 6, 2024
5 checks passed
@valkyria-gk valkyria-gk deleted the revert-40-mobhitting branch September 6, 2024 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants