Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use icon names from gnome-shell-extension-lockkeys #48

Open
1 of 5 tasks
mochaaP opened this issue Aug 19, 2023 · 4 comments
Open
1 of 5 tasks

Use icon names from gnome-shell-extension-lockkeys #48

mochaaP opened this issue Aug 19, 2023 · 4 comments
Labels
Config Option enhancement New feature or request

Comments

@mochaaP
Copy link
Contributor

mochaaP commented Aug 19, 2023

Support system icon theme settings.
Also, allow discrimination between enabled/disabled state

  • ask upstream (1, 2) for scroll lock support / drop scroll lock support on our side
  • use icons glyphs from upstream (1)
  • switch to Adwaita's icon name for audio / microphone
  • add option to discard gresource from binary / loading from external location (required for distribution packaging)
  • fix error on cargo package
@ErikReider ErikReider added enhancement New feature or request Config Option labels Nov 22, 2023
@ErikReider
Copy link
Owner

bb83b26 fixes the cargo package issue.

add option to discard gresource from binary / loading from external location (required for distribution packaging)

Why would this be necessary?

@mochaaP
Copy link
Contributor Author

mochaaP commented Nov 22, 2023

@ErikReider:

Why would this be necessary?

This mutates the source tree (usage of include_bytes) when invoking build.rs, which could cause some weird behavior while used alongside Fedora's Rust SRPM macros. (I forgot the exact details since it has been 3 months away from the original attempt, sorry 😅)

@ErikReider
Copy link
Owner

ErikReider commented Dec 8, 2023

@ErikReider:

Why would this be necessary?

This mutates the source tree (usage of include_bytes) when invoking build.rs, which could cause some weird behavior while used alongside Fedora's Rust SRPM macros. (I forgot the exact details since it has been 3 months away from the original attempt, sorry 😅)

What would be an alternative?

@ErikReider
Copy link
Owner

20d23ea removes the need for decoupling the gresource from the application

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Config Option enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants