Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor enhancements to the Snippets Builder #60

Open
2 tasks
hhkaos opened this issue Oct 22, 2024 · 3 comments
Open
2 tasks

Minor enhancements to the Snippets Builder #60

hhkaos opened this issue Oct 22, 2024 · 3 comments
Assignees
Labels
good first issue Good for newcomers type/bug Something isn't working

Comments

@hhkaos
Copy link
Member

hhkaos commented Oct 22, 2024

I just noticed two things that could be improved:

  • Add multi-line support in the description field
  • Submit proposal button include duplicate info

Multi-line-support

This is not encoding properly the field:

Screenshot 2024-10-22 at 15 13 45

It should be:

"A JavaScript only snippet": {
  "prefix": "myConsoleLog",
  "scope": "javascript, css",
  "body": [
    "console.log("Hello Map");",
  ],
  "description": "Console log \"Hello Map\".\nThis is a multiline description"
}

Submit proposal button

Since the last PR, it's including some info that is redundant:
2024-10-22_15-16-00

@hhkaos hhkaos added good first issue Good for newcomers type/bug Something isn't working labels Oct 22, 2024
@BochaberiDaisy
Copy link
Contributor

@hhkaos, please assign me this issue.

@hhkaos
Copy link
Member Author

hhkaos commented Nov 26, 2024

sorry @BochaberiDaisy ! I missed this message!

@BochaberiDaisy
Copy link
Contributor

No problem!

BochaberiDaisy added a commit to BochaberiDaisy/arcgis-js-vscode-snippets that referenced this issue Dec 5, 2024
BochaberiDaisy added a commit to BochaberiDaisy/arcgis-js-vscode-snippets that referenced this issue Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers type/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants