Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Minor enhancements to the Snippets Builder #60 #67

Closed
wants to merge 2 commits into from
Closed

Fix: Minor enhancements to the Snippets Builder #60 #67

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
576855c
Fix: Snippet Builder Minor Enhancements[#60]
BochaberiDaisy Dec 5, 2024
521cebe
Fix: Snippet Builder Minor Enhancements[#60]
BochaberiDaisy Dec 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
83 changes: 38 additions & 45 deletions builder/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,15 +21,15 @@ let snippet = {
.join("\n");

return `[
${x}
]`;
${x}
]`;
},
toString: () => {
return `"${snippet.name}": {
"prefix": "${snippet.prefix}",
"scope": "${Array.isArray(snippet.scope) ? snippet.scope.join(', ') : ''}",
"body": ${snippet.parse(snippet.body)},
"description": "${snippet.desc}"
"description": "${snippet.desc.replace(/\n/g, '\\n')}"
}`;
},
};
Expand Down Expand Up @@ -60,16 +60,9 @@ function renderSnippet() {
const repoUrl = "https://github.com/Esri/arcgis-js-vscode-snippets";
const title = encodeURIComponent(`Snippet proposal: ${snippet.name}`);
const body = encodeURIComponent(`
Please specify which type of snippet it is:
* [ ] JavaScript snippet (*.js)
* [ ] TypeScript snippet (*.ts)
* [ ] HTML snippet (*.html)
* [ ] ...


---
**Prefix**: ${snippet.prefix}
**Description**: ${snippet.desc}
**Scope**: ${Array.isArray(snippet.scope) ? snippet.scope.join(', ') : ''}
**Snippet**:
\`\`\`js
${snippet.body}
Expand All @@ -89,46 +82,46 @@ const inputElement = document.getElementById("import-snippet");
if (inputElement) {
inputElement.addEventListener("change", (event) => {
const file = event.target.files[0];
console.log("Selected file:", file);
console.log("Selected file:", file);

if (file) {
const reader = new FileReader();
if (file) {
const reader = new FileReader();

reader.onload = function(e) {
try {
const fileContent = e.target.result;
console.log("File content:", fileContent);
reader.onload = function (e) {
try {
const fileContent = e.target.result;
console.log("File content:", fileContent);

const snippetObject = JSON.parse(fileContent);
const snippetObject = JSON.parse(fileContent);

const firstSnippet = Object.values(snippetObject)[0];
snippet.name = Object.keys(snippetObject)[0];
snippet.prefix = firstSnippet.prefix;
snippet.scope = firstSnippet.scope.split(', ');
snippet.body = firstSnippet.body.join('\n');
snippet.desc = firstSnippet.description;
const firstSnippet = Object.values(snippetObject)[0];
snippet.name = Object.keys(snippetObject)[0];
snippet.prefix = firstSnippet.prefix;
snippet.scope = firstSnippet.scope.split(', ');
snippet.body = firstSnippet.body.join('\n');
snippet.desc = firstSnippet.description;

document.getElementById("name").value = snippet.name;
document.getElementById("prefix").value = snippet.prefix;
document.getElementById("desc").value = snippet.desc;
document.getElementById("body").value = snippet.body;
document.getElementById("name").value = snippet.name;
document.getElementById("prefix").value = snippet.prefix;
document.getElementById("desc").value = snippet.desc;
document.getElementById("body").value = snippet.body;

document.querySelectorAll('#language-selection input[type="checkbox"]').forEach((checkbox) => {
const scopeValues = checkbox.value.split(',').map(scope => scope.trim());
checkbox.checked = snippet.scope.includes(checkbox.value);
checkbox.checked = scopeValues.some(scope => snippet.scope.includes(scope));
});
document.querySelectorAll('#language-selection input[type="checkbox"]').forEach((checkbox) => {
const scopeValues = checkbox.value.split(',').map(scope => scope.trim());
checkbox.checked = snippet.scope.includes(checkbox.value);
checkbox.checked = scopeValues.some(scope => snippet.scope.includes(scope));
});

renderSnippet();
renderSnippet();

} catch (error) {
console.error("Failed to parse the snippet JSON: ", error);
document.getElementById("snippets").innerText = "Error parsing JSON. Please upload a valid snippet.";
}
};
} catch (error) {
console.error("Failed to parse the snippet JSON: ", error);
document.getElementById("snippets").innerText = "Error parsing JSON. Please upload a valid snippet.";
}
};

reader.readAsText(file);
}
reader.readAsText(file);
}
});
} else {
console.error("Element with ID 'import-snippet' not found.");
Expand All @@ -143,9 +136,9 @@ copyButton.addEventListener("click", (event) => {
.then(() => {
copyButton.textContent = "Copied";
})
setTimeout(() => {
copyButton.textContent = "Copy";
}, 1000);
setTimeout(() => {
copyButton.textContent = "Copy";
}, 1000);
});

document.querySelectorAll("calcite-input:not([type='file'])").forEach((item) => {
Expand Down