Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tile] Long content overflows container #11170

Closed
2 of 6 tasks
jcfranco opened this issue Dec 30, 2024 · 3 comments
Closed
2 of 6 tasks

[tile] Long content overflows container #11170

jcfranco opened this issue Dec 30, 2024 · 3 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (dev) Issues logged by Calcite developers. calcite-components Issues specific to the @esri/calcite-components package. estimate - 3 A day or two of work, likely requires updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - high Issue should be addressed in the current milestone, impacts component or core functionality regression Issues that are caused by changes in a release, but were working before that.
Milestone
2025-02-06 - 3.0....

Comments

@jcfranco
Copy link
Member

Check existing issues

Actual Behavior

Long content no longer wraps and will overflow the tile container.

Expected Behavior

Long content wraps within tile's bounds.

Reproduction Sample

https://codepen.io/jcfranco/pen/QwLqGeR?editors=1000

Reproduction Steps

  1. Load the repro case and compare v2.4.0 with v2.5.0.
  2. Notice that content overflows in v2.5.0.

Reproduction Version

2.5.0

Relevant Info

Looks like it was introduced by this PR. cc @eriklharper

Screenshot tests do not include the overflowing content, so we may need to set a fixed, large size for overflowing screenshot tests.

Regression?

2.4.0

Priority impact

impact - p3 - not time sensitive

Impact

Possibly low impact as we have not had any reports regarding this regression.

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/calcite-ui-icons
  • @esri/eslint-plugin-calcite-components

Esri team

Calcite (dev)
@jcfranco jcfranco added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Dec 30, 2024
@github-actions github-actions bot added Calcite (dev) Issues logged by Calcite developers. calcite-components Issues specific to the @esri/calcite-components package. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive labels Dec 30, 2024
@geospatialem geospatialem added the regression Issues that are caused by changes in a release, but were working before that. label Jan 6, 2025
@geospatialem
Copy link
Member

Related: #11199

@geospatialem geospatialem added p - high Issue should be addressed in the current milestone, impacts component or core functionality 1 - assigned Issues that are assigned to a sprint and a team member. estimate - 3 A day or two of work, likely requires updates to tests. and removed 0 - new New issues that need assignment. labels Jan 6, 2025
@geospatialem geospatialem removed the needs triage Planning workflow - pending design/dev review. label Jan 6, 2025
@eriklharper eriklharper added 2 - in development Issues that are actively being worked on. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Jan 6, 2025
@eriklharper eriklharper mentioned this issue Jan 6, 2025
Merged
eriklharper added a commit that referenced this issue Jan 8, 2025
@eriklharper @driskull
fix(tile): wrap overflowing text content (#11213)
732933a 
**Related Issue:** #11170 

## Summary

This PR fixes an issue where overflowing content doesn't stay within the
outer bounds of the Tile.

---------

Co-authored-by: Matt Driscoll <[email protected]>
@eriklharper eriklharper added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Jan 8, 2025
@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned eriklharper Jan 8, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 8, 2025

Installed and assigned for verification.

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Jan 9, 2025
@geospatialem
Copy link
Member

Verified on the dev branch

image

benelan pushed a commit that referenced this issue Feb 8, 2025
@eriklharper @driskull @benelan
fix(tile): wrap overflowing text content (#11213)
3640f19 
**Related Issue:** #11170 

## Summary

This PR fixes an issue where overflowing content doesn't stay within the
outer bounds of the Tile.

---------

Co-authored-by: Matt Driscoll <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (dev) Issues logged by Calcite developers. calcite-components Issues specific to the @esri/calcite-components package. estimate - 3 A day or two of work, likely requires updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - high Issue should be addressed in the current milestone, impacts component or core functionality regression Issues that are caused by changes in a release, but were working before that.
Projects
None yet
Milestone
2025-02-06 - 3.0.0 Feb Breaking Chang...
Development

No branches or pull requests
4 participants
@jcfranco @eriklharper @geospatialem @DitwanP