Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit how many rows show in the related table #1030

Open
skrishn opened this issue Nov 21, 2024 · 2 comments
Open

Limit how many rows show in the related table #1030

skrishn opened this issue Nov 21, 2024 · 2 comments
Assignees
Labels
2-ENH New feature or request Reporter 4.x Crowdsource Reporter (new)
Milestone

Comments

@skrishn
Copy link
Collaborator

skrishn commented Nov 21, 2024

Description: Add an option for app authors to limit how many rows of characters appear in the related table title.
Location: Reporter > Panel Option > Add a header in the list for Comments
label: Show full comment title' ON by default Tooltip: When toggle off, only the first line of the comment will show`

limit how many rows show in the related table

@skrishn skrishn added 2-ENH New feature or request Reporter 4.x Crowdsource Reporter (new) labels Nov 21, 2024
@skrishn skrishn added this to the 2025.R01 milestone Nov 21, 2024
@skrishn skrishn self-assigned this Nov 21, 2024
@sumitzarkar
Copy link
Collaborator

@skrishn @jmhauck

Approach

  • We will add a property showFullCommentTitle in the reporter component
  • This will be true by default to support backward compatibility
  • Based on the property value we will add the CSS to show the comment title in one line or multiple lines
When showFullCommentTitle toggle on When showFullCommentTitle toggle is off
image image

Please let us know if any changes required in this

@pratiksabale07
Copy link
Collaborator

@skrishn

Cause

This is an enhancement requested by the client.


Solution

  • Add some custom CSS for the comments list's title to show ellipsis.

Dev Checklist

Items Is required Status Comments
Required NLS changes? No
Required Backward compatibility Yes
Required 508 No
Need Sanitize? No

Impact Analysis Report

Impacted Areas Comments
Have Configuration changes? No
Have Runtime changes? Yes
Impact on RTL Yes
Impacted components - Features List
- Comments List
Impact on Runtime If showFullCommentTitle is enabled from the configuration, the comment title should display multiple lines.
If showFullCommentTitle is disabled from the configuration, the comment title should display an ellipsis when the text overflows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2-ENH New feature or request Reporter 4.x Crowdsource Reporter (new)
Projects
None yet
Development

No branches or pull requests

3 participants