Downloading the toolbox creates broken links in models

[topowright-zz]

When downloading the toolbox to make changes I have noticed that there are broken links on all tools.

┆Issue is synchronized with this Asana task

[topowright-zz]

@mfunk Is this still an issue?

[mfunk]

@topowright I haven't tried it but I assume that it still is.

[adgiles]

Downloaded the toolbox and opened in ArcMap 10.4.1. I could only see two tools that had broken links:

Append Message File from Military Feature Workspace
AppendMilitaryFeaturesFromWorkspace

@csmoore Chris are/have you been working on these lately?

[csmoore]

I believe this issue predates that toolbox (Military Features Tools) being added to the repo.

But for this toolbox, I guess the last change (not by me at #612 ) was done on a later version so this issue should be fixed - might be good to see if this issue also exists in the download item : http://esriurl.com/AFMMilFeatures

[adgiles]

That change #612 was removing the references to App6 I thought you were putting them back in. Seem like we go round in circles with these issues

[topowright-zz]

We are now adding the APP6

[topowright-zz]

This issue has been addressed by adding APP6 and hopefully fixing the broken link.

[topowright-zz]

Changed the topic to adding APP6b

[csmoore]

@topowright - I just noticed this was assigned to me for this sprint - I can look at after the PR in #644 is complete

[topowright-zz]

@csmoore I am breaking this issue up into two issues to avoid confusion. This issue will be associated with the broken links issue when a toolbox is pulled out of Github to be then used in ArcGIS. Talking with you today you seem to think that this is able to be fixed by just validating the tools and rerunning the tools once. I have a different experience that it is something that cannot be figured out based on working with @mfunk and core to find out what Github does to make some of our tools not work.