avatar: true is required for mc-to-discord-name-format to take any effect

[WildPenquin]

Type of bug

Other unexpected behaviour

/ess dump all output

https://essentialsx.net/dump.html?id=ac2cc41dd84d415daba792834b01f9fc

Error log (if applicable)

No response

Bug description

Hi,

I've been scratching my head over why doesn't setting mc-to-discord-name-format: take any effect.

Finally, I noticed I need to set
show-avatar: true

Keeping it false, the option does not work.

Either this is unintentional or the documentation / comments need updating.

Steps to reproduce

Set:
show-avatar: false

Edit mc-to-discord-name-format: to your liking, something which it was not before.

Finally, /ess reload or restart the whole server and make some messages appear in Discord.

Expected behaviour

The "app" name should change for Discord bridge (messages, joins etc.).

Actual behaviour

The name does not change from the default.

Additional Information

No response