You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The \EthanYehuda\CronjobManager\Helper\Processor::runJob() method has 99% the same code of Processor::runScheduledJob().
The only difference between these two methods is when the schedule object is saved: runJob() directly call the save() method of the schedule object itself (which is deprecated according to Magento 2 best practices) whereas runScheduledJob() runs the save() method from the object getResource().
I think runJob() should be deleted if possible, or at least being updated as deprecated and pointing to runScheduledJob() method.
The text was updated successfully, but these errors were encountered:
The
\EthanYehuda\CronjobManager\Helper\Processor::runJob()
method has 99% the same code ofProcessor::runScheduledJob()
.The only difference between these two methods is when the schedule object is saved:
runJob()
directly call thesave()
method of the schedule object itself (which is deprecated according to Magento 2 best practices) whereasrunScheduledJob()
runs thesave()
method from the objectgetResource()
.I think
runJob()
should be deleted if possible, or at least being updated as deprecated and pointing torunScheduledJob()
method.The text was updated successfully, but these errors were encountered: