This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
Fix identity-provider type issues & patch @feathersjs/knex
#10971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CITIZENDOT
requested review from
barankyle,
MoizAdnan,
hanzlamateen,
hurairahmateen,
aditya-mitra and
HexaField
as code owners
Fix type errors
Comment out wallet related functions
CITIZENDOT
changed the title
guest & admin identity provider types
CITIZENDOT
changed the title
@feathersjs/knex
hanzlamateen
approved these changes
Aug 15, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
guest)@featherjs/knexto fixtotalcalculation: Fixes the issue where thetotalis incorrectly calculated whenGROUP BYorDISTINCTclauses are used.Subtasks Checklist
Breaking Changes
References
closes https://tsu.atlassian.net/browse/IR-3920
QA Steps