This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
Added a function to clean project names for k8s #10988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current solution was leaving dashes at the start or end of labels if they started or ended with invalid characters. The characters were replaced by dashes, but k8s does not allow dashes at the start or end. Fixed a bug where new projects where existingProject.id was being read from even if existingProject didn't exist. Now reading from returned.id; returned always exists.
barankyle
requested review from
MoizAdnan,
hanzlamateen,
hurairahmateen and
aditya-mitra
as code owners
HexaField
approved these changes
Aug 16, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Current solution was leaving dashes at the start or end of labels if they started or ended with invalid characters. The characters were replaced by dashes, but k8s does not allow dashes at the start or end.
Fixed a bug where new projects where existingProject.id was being read from even if existingProject didn't exist. Now reading from returned.id; returned always exists.
Subtasks Checklist
Breaking Changes
References
closes #insert number here
QA Steps