Skip to content
This repository has been archived by the owner on Aug 21, 2024. It is now read-only.

Nginx setup #9180

Draft
wants to merge 29 commits into
base: dev
Choose a base branch
from
Draft

Nginx setup #9180

wants to merge 29 commits into from

Conversation

mrhegemon
Copy link
Contributor

@mrhegemon mrhegemon commented Oct 31, 2023

Summary

🤖 Generated by Copilot at c3327d5

This pull request enhances the local development environment by adding variables and logic for the media server instance, enabling nginx proxying, and allowing different methods of generating SSL certificates. It modifies the .env.local.default file, the packages/client-core, packages/client, packages/server-core, and packages/server files, the scripts files, and the docker-compose-services.yml file. It also removes the docker-compose.yml file.

References

closes #insert number here

Explanation

🤖 Generated by Copilot at c3327d5

  • Added and modified environment variables for app title, media server domain and port, SMTP from email, and nginx overrides in .env.local.default (link, link, link, link)
  • Added and modified scripts for generating SSL certificates using mkcert or openssl in scripts (link, link, link)
  • Added and modified nginx configuration files for reverse proxying the app, api, file, instance, and media servers in scripts/nginx (link, link, link)
  • Modified server files to use environment variables for SSL key and certificate paths in packages/client, packages/server-core, and packages/server (link, link, link, link)
  • Modified connectToNetwork function to include server query parameter for routing requests to instance or media server in packages/client-core (link, link)
  • Modified get-local-server-ip function to use media server domain and port if isMediaInstance is true in packages/server-core (link)
  • Added media server domain and port properties to instanceserver object in packages/server-core (link)
  • Modified killports function to use media server port from configuration in scripts/run_e2e_tests.ts (link)
  • Removed docker-compose.yml file and added command to source .env.local file in start-containers.sh in scripts (link, link)

🤖 Generated by Copilot at 9b51a35

Sing, O Muse, of the valiant deeds of the coders
Who, with skill and wisdom, improved the web app's features
They changed the package.json and the server.js files
To make the SSL certificates more flexible and secure

QA Steps

List any additional steps required to QA the changes of this PR, as well as any supplemental images or videos.

Checklist

  • If this PR is still a WIP, convert to a draft
  • When this PR is ready, mark it as "Ready for review"
  • ensure all checks pass
  • Changes have been manually QA'd
  • Changes reviewed by at least 2 approved reviewers

@DanielBelmes
Copy link
Contributor

Went over with Kyle. Docker Desktop is apparently a requirement for passing host.docker.internal to the container. There's a multitude of ways to have a container talk to the hosts network. We can also just use DNS and subdomains. Furthermore, kyle showed me how to test the webrtc connections. So I should be able to configure nginx for them. Lastly, I have to configure minio.

@DanielBelmes
Copy link
Contributor

Was seeing issues where when a website was adblocked it would server the nginx server. Want to investigate that.

Copy link

cla-bot bot commented Nov 10, 2023

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Daniel Belmes.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

Copy link

cla-bot bot commented Nov 12, 2023

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Daniel Belmes.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

Copy link

cla-bot bot commented Nov 15, 2023

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Daniel Belmes.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@DanielBelmes DanielBelmes self-assigned this Nov 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants