From f546ff1edc9c03ddb919d7becc2050b99de85922 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Stefan=20Negovanovi=C4=87?= Date: Tue, 13 Feb 2024 15:18:39 +0100 Subject: [PATCH] Lint fix --- types/access_list_tx.go | 8 ++++++-- types/dynamic_fee_tx.go | 8 ++++++-- types/legacy_tx.go | 8 ++++++-- types/rlp_unmarshal.go | 1 + types/state_tx.go | 8 ++++++-- 5 files changed, 25 insertions(+), 8 deletions(-) diff --git a/types/access_list_tx.go b/types/access_list_tx.go index 2663b304e7..2a3b5a01f6 100644 --- a/types/access_list_tx.go +++ b/types/access_list_tx.go @@ -204,9 +204,13 @@ func (tx *AccessListTxn) setHash(h Hash) { // Use UnmarshalRLP in most cases func (tx *AccessListTxn) unmarshalRLPFrom(p *fastrlp.Parser, v *fastrlp.Value) error { numOfElems := 11 - var values rlpValues - values, err := v.GetElems() + var ( + values rlpValues + err error + ) + + values, err = v.GetElems() if err != nil { return err } diff --git a/types/dynamic_fee_tx.go b/types/dynamic_fee_tx.go index 383745adb9..b5352683d3 100644 --- a/types/dynamic_fee_tx.go +++ b/types/dynamic_fee_tx.go @@ -97,9 +97,13 @@ func (tx *DynamicFeeTx) setHash(h Hash) { tx.Hash = h } // Use UnmarshalRLP in most cases func (tx *DynamicFeeTx) unmarshalRLPFrom(p *fastrlp.Parser, v *fastrlp.Value) error { numOfElems := 12 - var values rlpValues - values, err := v.GetElems() + var ( + values rlpValues + err error + ) + + values, err = v.GetElems() if err != nil { return err } diff --git a/types/legacy_tx.go b/types/legacy_tx.go index b6e4a4f6be..23af43bd10 100644 --- a/types/legacy_tx.go +++ b/types/legacy_tx.go @@ -91,9 +91,13 @@ func (tx *LegacyTx) setHash(h Hash) { tx.Hash = h } // Use UnmarshalRLP in most cases func (tx *LegacyTx) unmarshalRLPFrom(p *fastrlp.Parser, v *fastrlp.Value) error { num := 9 - var values rlpValues - values, err := v.GetElems() + var ( + values rlpValues + err error + ) + + values, err = v.GetElems() if err != nil { return err } diff --git a/types/rlp_unmarshal.go b/types/rlp_unmarshal.go index fef4710627..480acbe54d 100644 --- a/types/rlp_unmarshal.go +++ b/types/rlp_unmarshal.go @@ -390,6 +390,7 @@ func (r *rlpValues) dequeueValue() *fastrlp.Value { if len(*r) == 0 { return nil } + val := (*r)[0] *r = (*r)[1:] diff --git a/types/state_tx.go b/types/state_tx.go index e0eaf3c72e..52c86e3f3b 100644 --- a/types/state_tx.go +++ b/types/state_tx.go @@ -94,9 +94,13 @@ func (tx *StateTx) setHash(h Hash) { tx.Hash = h } // Use UnmarshalRLP in most cases func (tx *StateTx) unmarshalRLPFrom(p *fastrlp.Parser, v *fastrlp.Value) error { numOfElems := 10 - var values rlpValues - values, err := v.GetElems() + var ( + values rlpValues + err error + ) + + values, err = v.GetElems() if err != nil { return err }