Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix for flaky test #117

Merged
merged 8 commits into from
Feb 23, 2024
Merged

fix for flaky test #117

merged 8 commits into from
Feb 23, 2024

Conversation

dusannosovic-ethernal
Copy link

Description

This PR includes changes for flaky TestE2E_Bridge_NonMintableERC20Token_WithPremine

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

@dusannosovic-ethernal dusannosovic-ethernal self-assigned this Feb 14, 2024
@dusannosovic-ethernal dusannosovic-ethernal marked this pull request as ready for review February 17, 2024 10:22
@dusannosovic-ethernal dusannosovic-ethernal force-pushed the fix-for-flaky-TestE2E-Bridge-NonMintableERC20Token-WithPremine branch 2 times, most recently from 7e0d648 to 56a7b02 Compare February 21, 2024 07:56
goran-ethernal
goran-ethernal previously approved these changes Feb 22, 2024
View reviewed changes
@dusannosovic-ethernal dusannosovic-ethernal force-pushed the fix-for-flaky-TestE2E-Bridge-NonMintableERC20Token-WithPremine branch from 4514be9 to 9fdeb11 Compare February 22, 2024 09:16
@dusannosovic-ethernal dusannosovic-ethernal force-pushed the fix-for-flaky-TestE2E-Bridge-NonMintableERC20Token-WithPremine branch from 0a42736 to c3fc7cf Compare February 23, 2024 12:01
@Stefan-Ethernal Stefan-Ethernal merged commit 08e947f into develop Feb 23, 2024
7 of 9 checks passed
@Stefan-Ethernal Stefan-Ethernal deleted the fix-for-flaky-TestE2E-Bridge-NonMintableERC20Token-WithPremine branch February 23, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goran-ethernal goran-ethernal goran-ethernal approved these changes

@Stefan-Ethernal Stefan-Ethernal Stefan-Ethernal approved these changes

Assignees

@dusannosovic-ethernal dusannosovic-ethernal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dusannosovic-ethernal @Stefan-Ethernal @goran-ethernal