Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement missing JSON RPC functions #66

Conversation

Stefan-Ethernal
Copy link

Description

The PR implements eth_accounts and eth_sendTransaction functions. Also, it defaults some fields (if omitted) in the transaction when eth_sendTransaction is being invoked.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the relevant labels
  • I have updated the official documentation
  • I have added sufficient documentation in code

Testing

  • I have tested this code with the official test suite
  • I have tested this code manually

Manual tests

Please complete this section if you ran manual tests for this functionality, otherwise delete it

Documentation update

Please link the documentation update PR in this section if it's present, otherwise delete it

Additional comments

Please post additional comments in this section if you have them, otherwise delete it

@Stefan-Ethernal Stefan-Ethernal force-pushed the feat/implement-missing-jsonrpc-functions branch from 01f049e to d01a43d Compare December 28, 2023 13:01
@goran-ethernal goran-ethernal force-pushed the feat/implement-missing-jsonrpc-functions branch from 1f080ea to 6a83885 Compare December 29, 2023 08:57
@Stefan-Ethernal Stefan-Ethernal force-pushed the feat/implement-missing-jsonrpc-functions branch from 6a83885 to 48ce193 Compare December 29, 2023 09:16
@goran-ethernal goran-ethernal force-pushed the BLADE-64-Deploy-AA-contracts-on-Blade branch 2 times, most recently from e8a8372 to 17fab1e Compare February 20, 2024 11:59
@goran-ethernal goran-ethernal force-pushed the feat/implement-missing-jsonrpc-functions branch from 085d1f9 to 795a5d0 Compare February 20, 2024 12:01
@goran-ethernal goran-ethernal force-pushed the BLADE-64-Deploy-AA-contracts-on-Blade branch from 17fab1e to 35161a0 Compare February 26, 2024 08:41
@goran-ethernal goran-ethernal force-pushed the feat/implement-missing-jsonrpc-functions branch from 795a5d0 to 8f35c73 Compare February 26, 2024 08:42
@goran-ethernal goran-ethernal deleted the feat/implement-missing-jsonrpc-functions branch June 26, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants