Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow retrieving big detector data with cell IDs in the index instead of pulse IDs #101

Merged
merged 2 commits into from
Jan 5, 2021

Conversation

takluyver
Copy link
Member

This would be used like this:

lpd = LPD1M(run)
lpd.get_array('image.data', subtrain_index='cellId')

Might be relevant for #100

@takluyver takluyver added the enhancement New feature or request label Nov 9, 2020
@takluyver
Copy link
Member Author

This crucially assumes that different modules use the same cell ID for the same frame, because it will align the data by cell ID. If different modules can be on different cells at the same time, this should not be used!

Copy link

@daviddoji daviddoji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Sorry for the late review!

@takluyver takluyver added this to the 1.4 milestone Jan 5, 2021
@takluyver takluyver merged commit 86d8d97 into master Jan 5, 2021
@takluyver takluyver deleted the det-get-array-cellid branch January 5, 2021 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants