Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use loose typing to simplify conditionals #16

Open
nickdesaulniers opened this issue Mar 22, 2013 · 0 comments
Open

Use loose typing to simplify conditionals #16

nickdesaulniers opened this issue Mar 22, 2013 · 0 comments

Comments

@nickdesaulniers
Copy link

Because types in JavaScript are loosely defined and be coerced at runtime this line can be rewritten:

if (oauthtoken && noteStoreUrl && shardUrl) {

if any of the above are undefined or the empty string, those values are falsy and evaluate to false. Please do not ever do variable != 'undefined'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nickdesaulniers