Propose a docker-compose simplified approach without init container. #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current base setup for Midpoint native on docker is using a dedicated container for initialization of the database. This init container requires to be based on the same base image as the midpoint server itself. Both midpoint and init use a custom command for container initialization and we have to duplicate DB environment variables.
I think it would be preferable to avoid this by having midpoint run the initialization scripts before startup. I would even suggest if you could maintain a set of docker images that would have this initialization hardcoded on tags like 4.8.3-native-alpine for instance ? This way we could bootstrap images in Docker compose or Kubernetes cluster much more conveniently.