-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ILL Borrowing module #14
Open
dongchch2016
wants to merge
22
commits into
nacsis-cat-ill
Choose a base branch
from
nacsis-create-borrowing-requests
base: nacsis-cat-ill
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
included:NACSIS ILL request creation;Search Bibliographic records in NACSIS
Fxied some bugs: concatenated issue. extractNacsisId() function. Display issue.
Added table display first time.
Add table features.
add view holding and member info into expandable row.
Add request forms and view member info. Fixed some UI issues.
Add create ILL request logic and remove some unused code.
Fix view member info UI issue.
add error property. need to add to other places using getIntegrationProfile. all callbacks in RxJS are wrapped with try-catch blocks so it'll be caught and then sent as an error notification.
Fix some UI issues and finish creating ILL request.
keep the previous page data when going back page. Fix some 'null' back.
Sync en.json and jp.json
Fix some translation bug and add Japanese translation
Remove unused translation
Add translation for member info
Add translation for paginator
complete the jp.json translation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
included:NACSIS ILL request creation;Search Bibliographic records in NACSIS