Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow update of printer profiles #43

Closed
dregad opened this issue Feb 23, 2022 · 4 comments
Closed

Allow update of printer profiles #43

dregad opened this issue Feb 23, 2022 · 4 comments
Assignees
@mgobat
Labels
enhancement New feature or request

Comments

@dregad
Copy link

dregad commented Feb 23, 2022

Currently (2.0.0-beta-03) the configuration dialog does not allow the user to edit existing printer profiles. To make a change, the only way is to delete the profile, then add it back.

This was not much of a problem before, but with the additional settings (paper format, margins, etc) that sometimes require some tweaking, it's becoming more of a hassle.
@mgobat mgobat added the enhancement New feature or request label Feb 23, 2022
@mgobat mgobat self-assigned this May 6, 2022
mgobat added a commit that referenced this issue May 13, 2022
@mgobat
2.1.0
8ea2f90 
Add ability to edit printer profiles, GitHub issue #43.
Add ability to define a custom format with page height and width, GitHub issue #53 (sort of).
@mgobat
Copy link
Contributor

mgobat commented May 13, 2022

Available in 2.1.0-beta1 release, https://github.com/ExLibrisGroup/alma-print-daemon/releases/tag/v2.1.0-beta1. Pre-release, use in test before rolling out to everyone.

@dregad
Copy link
Author

dregad commented Sep 7, 2022

I tested the edit functionality this morning on 2.1.0-beta2 release and it seems to work as expected.

That being said, considering #44 I'm not sure what is actually happening to the profiles when edited by multiple users. I'll perform some additional tests in coordination with a colleague later and get back to you.

@mgobat
Copy link
Contributor

mgobat commented Sep 14, 2022

@dregad, thank you for testing this enhancement. Each user should have their own alma-print-config.json file in C:\Users<username>\AppData\Roaming\alma-print-daemon.

@mgobat
Copy link
Contributor

mgobat commented Mar 8, 2023

Editing existing printer profiles available in version 2.1.0.

@mgobat mgobat closed this as completed Mar 8, 2023
mgobat added a commit that referenced this issue Mar 9, 2023
@mgobat
2.1.0 (#71)
deb658e 
* 2.1.0

Add ability to edit printer profiles, GitHub issue #43.
Add ability to define a custom format with page height and width, GitHub issue #53 (sort of).

* Use pre-2.0 method of printing if not running as a Windows service

This is issues #53 and #55.
Also fix GitHub issue #35.

* Remove auto update

Remove auto update and fix GitHub issue #35 during initial configuration.

* Remove beta version indication
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mgobat mgobat

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dregad @mgobat