Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specification: what happens on callback failures? #133

Open
andre-merzky opened this issue Apr 17, 2021 · 1 comment
Open

Specification: what happens on callback failures? #133

andre-merzky opened this issue Apr 17, 2021 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@andre-merzky
Copy link
Collaborator

The specification is currently silent on implementation behavior when state notification callbacks raise an exception.

I suggest that we define that exceptions are ignored (but SHOULD be logged). It is the responsibility of the application to make sure the cb is safe.

@andre-merzky andre-merzky added the enhancement New feature or request label Apr 17, 2021
@hategan
Copy link
Collaborator

hategan commented Apr 18, 2021

Yes, I think an implementation note encouraging implementations to ignore but loudly log CB exceptions is a good idea.

@andre-merzky andre-merzky self-assigned this Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants