Done. ✔️
P.S: mind if I replace relative layout elements with the better constraint layouts?

P.S: mind if I replace relative layout elements with the better constraint layouts?

Ok to improve layout but this changes have an impact on differents configurations layouts ?
Because we have planned to add a new layout for tablet #296

Just like the fragment_about.xml we can add multiple different layouts,

• one normal for portrait mode
• another in res/layout-w600dp (For 7” tablets, 600dp)
• another in res/layout-w720dp (For 10” tablets 720dp)
  and so on?

Ok, but add screenshots foreach config to see difference

There won't be any changes visually. UI will remain as it is right now. Just changes in xml layouts code. Later when we add multiple layouts for tablets, things can be re-arranged for tablet specific views like you showed in the screenshot in #296

Ok, go on

Done. All nested layouts have been flattened.

• Please reduce space between elements in App Fragment (Same space as app in trackerdetails Fragment
• Sub permission Fragment is broken, exodus show only 10 permissions, and can you reduce space between elements
• Percentage bar in tracker Fragment is broken, when percentage is 100%, bar is cut at the right of the screen

• Please reduce space between elements in App Fragment

Done

• Sub permission Fragment is broken, exodus show only 10 permissions, and can you reduce space between elements

Hmm, for me it started showing 11 items. couldn't figure out why, so reverted this back to relative layout.

• Percentage bar in tracker Fragment is broken, when percentage is 100%, bar is cut at the right of the screen

In android studio the layout is being rendered correctly. I already added marginEnd=30dp and it showed ample amount of space on the right. Didn't even reach the > on the right. But when testing on device, progressbar doesn't seem to respect margin values. So reverting this layout too.

• Reduce space between appAVTV and appAnalyzedVersionTV in app_details_fragment
• Please check com.google.android.material.imageview.ShapeableImageView in recycler view app item and fragment app details, apps icon are cut in somes cases

I have start tests on theming:

• Can you add checkbox or switch to enable OLED mode on comptatible devices ?
• Change theming doesn't work on android 5.0

• Reduce space between appAVTV and appAnalyzedVersionTV in app_details_fragment

• Please check com.google.android.material.imageview.ShapeableImageView in recycler view app item and fragment app details, apps icon are cut in somes cases

fixed

Layout looks good

• Can you add checkbox or switch to enable OLED mode on comptatible devices ?

Unfortunately, I don't know how to. Since there is no inbuilt method for this, we probably have to define a custom style with all the colors (background, status bar, nav bar, fab everything). When user selects checkbox/switch we'd have to set the theme/style to our custom oled style. When user unchecks, we'd again set it back to base theme. That's the idea at least, but last time I tried this, it didn't work, so 🤷

• Change theming doesn't work on android 5.0

Maybe we show the theme option only for sdk > 21? 🤔
According to #283 support for sdk 21 & 22 will be dropped soon any way.

I have check on others Android apps, to detect OLED mode, apps check configuration -> https://developer.android.com/develop/ui/views/theming/darktheme#java
For OLED theme, apply dark theme with black background (not need create a new style)

I used apps with dark theme in API 21 (NewPipe, Organic Maps, VLC), i think it's doesn't work because, we don't have Base.V21 Theme in our styles

• For OLED theme, apply dark theme with black background (not need create a new style)

• we don't have Base.V21 Theme in our styles

okay it's done. You can do the // TODO stuff and it will be fully working.

I'm not a developer, i try to maintain project but i'm not expert.
I can give you somes help to finish Theme option.
Can you create separate PR to theme option, i want merge scrollbar fix.

I have noticed somes things, on theme option:

• Android top bar and bottom bar doesn't respect colorPrimary in Android 21
• I we want add oled mode, you need to add OK button to validate selection

Can you create separate PR to theme option, i want merge scrollbar fix.

Yeah sure no problem. :)

* I we want add oled mode, you need to add `OK` button to validate selection

Why 🤔 You just check the checkbox and it switches to OLED mode directly and vice versa.

On other app, to enable oled mode, we need to select dark mode before enable oled

Yeah same here too. The OLED mode will only be enabled if dark mode is selected, or if it's follow system and the system theme is dark mode. I've handled that part already. All that remains is the // TODO stuff to set the checked values in preferences.

In somes cases, if i want enable OLED mode.
I select dark mode in pop-up -> pop-up is closed
I need to re-open pop-up to select OLED mode.

Hmm, okay I'll do it when I split the theme stuff into a new pull request. Will do in a couple of days.

Reverted theme stuff so it now only has scrollbar fixes and layout changes.
Here's the separate theme PR: #321

Thanks, can you remove commits about theming ?

okay I'm pretty sure I removed the correct commits relating to theme. Please check & confirm.