From c86a0dd835212bf25c937d2b3bbf12d678dedeb3 Mon Sep 17 00:00:00 2001 From: andrew Date: Mon, 14 Dec 2020 12:38:31 -0700 Subject: [PATCH] Fixes two bugs with actions found: 1. Duplicate actions run, now we only run against pull_request 2. Fixes path to CLA document --- .github/workflows/cla.yml | 2 +- .github/workflows/e2e.yml | 8 +------- .github/workflows/lint.yml | 8 +------- .github/workflows/test.yml | 8 +------- 4 files changed, 4 insertions(+), 22 deletions(-) diff --git a/.github/workflows/cla.yml b/.github/workflows/cla.yml index 939e8ed72f3e..0ff2de439545 100644 --- a/.github/workflows/cla.yml +++ b/.github/workflows/cla.yml @@ -18,7 +18,7 @@ jobs: PERSONAL_ACCESS_TOKEN : ${{ secrets.BOTIFY_TOKEN }} with: path-to-signatures: '${{ github.repository }}/cla.json' - path-to-document: '${{ github.repository }}/blob/master/CLA.md' + path-to-cla-document: 'https://github.com/${{ github.repository }}/blob/master/CLA.md' branch: 'master' remote-organization-name: 'Expensify' remote-repository-name: 'CLA' diff --git a/.github/workflows/e2e.yml b/.github/workflows/e2e.yml index b8aed60f6fe3..c9770f4f0055 100644 --- a/.github/workflows/e2e.yml +++ b/.github/workflows/e2e.yml @@ -1,13 +1,7 @@ name: E2E iOS Tests on: - push: - branches-ignore: - - 'master' - - 'version-bump-*' - tags-ignore: - - '*' - pull_request_target: + pull_request: types: [opened, synchronize] env: diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index c606d716bd7b..3ab86924388f 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -1,13 +1,7 @@ name: Lint JavaScript on: - push: - branches-ignore: - - 'master' - - 'version-bump-*' - tags-ignore: - - '*' - pull_request_target: + pull_request: types: [opened, synchronize] jobs: diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index ee83676f7305..6bd6f9015350 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -1,13 +1,7 @@ name: Jest Unit Tests on: - push: - branches-ignore: - - 'master' - - 'version-bump-*' - tags-ignore: - - '*' - pull_request_target: + pull_request: types: [opened, synchronize] jobs: