From 6e08aef1427e176de6699cbc35e73305722f95fd Mon Sep 17 00:00:00 2001 From: someone-here Date: Fri, 9 Feb 2024 20:19:58 +0530 Subject: [PATCH 1/3] Change the global create and DM create tooltips to read Create --- src/components/FloatingActionButton.tsx | 2 +- src/languages/en.ts | 1 + src/languages/es.ts | 1 + .../report/ReportActionCompose/AttachmentPickerWithMenuItems.js | 2 +- 4 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/components/FloatingActionButton.tsx b/src/components/FloatingActionButton.tsx index 17da0cebbd5f..728736348f1e 100644 --- a/src/components/FloatingActionButton.tsx +++ b/src/components/FloatingActionButton.tsx @@ -103,7 +103,7 @@ function FloatingActionButton({onPress, isActive, accessibilityLabel, role}: Flo }; return ( - + )} - + { From 290cf709d377304b362e725f8c083de31e0fbd2a Mon Sep 17 00:00:00 2001 From: someone-here Date: Sun, 11 Feb 2024 18:51:08 +0530 Subject: [PATCH 2/3] Additional modifications --- src/languages/en.ts | 1 - src/languages/es.ts | 1 - .../report/ReportActionCompose/AttachmentPickerWithMenuItems.js | 2 +- tests/perf-test/ReportActionCompose.perf-test.js | 2 +- 4 files changed, 2 insertions(+), 4 deletions(-) diff --git a/src/languages/en.ts b/src/languages/en.ts index 5a47c62880b9..b2e869f244b7 100755 --- a/src/languages/en.ts +++ b/src/languages/en.ts @@ -422,7 +422,6 @@ export default { oneMoment: "One moment while we redirect you to your company's single sign-on portal.", }, reportActionCompose: { - addAction: 'Actions', dropToUpload: 'Drop to upload', sendAttachment: 'Send attachment', addAttachment: 'Add attachment', diff --git a/src/languages/es.ts b/src/languages/es.ts index c2ceecee6256..58bf9879fe30 100644 --- a/src/languages/es.ts +++ b/src/languages/es.ts @@ -412,7 +412,6 @@ export default { oneMoment: 'Un momento mientras te redirigimos al portal de inicio de sesión único de tu empresa.', }, reportActionCompose: { - addAction: 'Acción', dropToUpload: 'Suelta el archivo aquí para compartirlo', sendAttachment: 'Enviar adjunto', addAttachment: 'Añadir archivo adjunto', diff --git a/src/pages/home/report/ReportActionCompose/AttachmentPickerWithMenuItems.js b/src/pages/home/report/ReportActionCompose/AttachmentPickerWithMenuItems.js index 211668cc6656..62abfcf8545a 100644 --- a/src/pages/home/report/ReportActionCompose/AttachmentPickerWithMenuItems.js +++ b/src/pages/home/report/ReportActionCompose/AttachmentPickerWithMenuItems.js @@ -293,7 +293,7 @@ function AttachmentPickerWithMenuItems({ style={styles.composerSizeButton} disabled={isBlockedFromConcierge || disabled} role={CONST.ROLE.BUTTON} - accessibilityLabel={translate('reportActionCompose.addAction')} + accessibilityLabel={translate('common.create')} > { const scenario = async () => { // Query for the attachment button - const hintAttachmentButtonText = Localize.translateLocal('reportActionCompose.addAction'); + const hintAttachmentButtonText = Localize.translateLocal('common.new'); const attachmentButton = await screen.findByLabelText(hintAttachmentButtonText); fireEvent.press(attachmentButton, mockEvent); From 4122e5330ed58b73ada05c731b72148d19f8f9cb Mon Sep 17 00:00:00 2001 From: someone-here Date: Thu, 15 Feb 2024 17:09:18 +0530 Subject: [PATCH 3/3] Fix tests --- tests/perf-test/ReportActionCompose.perf-test.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/perf-test/ReportActionCompose.perf-test.js b/tests/perf-test/ReportActionCompose.perf-test.js index 0628fd753e0d..5b70666632f9 100644 --- a/tests/perf-test/ReportActionCompose.perf-test.js +++ b/tests/perf-test/ReportActionCompose.perf-test.js @@ -115,7 +115,7 @@ test('[ReportActionCompose] should render Composer with text input interactions' test('[ReportActionCompose] should press add attachemnt button', async () => { const scenario = async () => { // Query for the attachment button - const hintAttachmentButtonText = Localize.translateLocal('common.new'); + const hintAttachmentButtonText = Localize.translateLocal('common.create'); const attachmentButton = await screen.findByLabelText(hintAttachmentButtonText); fireEvent.press(attachmentButton, mockEvent);