From 0c450be272303c7041db20b44246715294ab6033 Mon Sep 17 00:00:00 2001 From: Aman Sheikh Date: Thu, 14 Sep 2023 18:59:33 +0530 Subject: [PATCH 1/2] rename to appropriate style name --- src/components/SignInButtons/AppleSignIn/index.desktop.js | 2 +- src/components/SignInButtons/GoogleSignIn/index.desktop.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/components/SignInButtons/AppleSignIn/index.desktop.js b/src/components/SignInButtons/AppleSignIn/index.desktop.js index 425e88ddf930..52ff3ef710b0 100644 --- a/src/components/SignInButtons/AppleSignIn/index.desktop.js +++ b/src/components/SignInButtons/AppleSignIn/index.desktop.js @@ -14,7 +14,7 @@ const appleSignInWebRouteForDesktopFlow = `${CONFIG.EXPENSIFY.NEW_EXPENSIFY_URL} */ function AppleSignIn() { return ( - + { window.open(appleSignInWebRouteForDesktopFlow); diff --git a/src/components/SignInButtons/GoogleSignIn/index.desktop.js b/src/components/SignInButtons/GoogleSignIn/index.desktop.js index bdba2052d664..95a78f34614b 100644 --- a/src/components/SignInButtons/GoogleSignIn/index.desktop.js +++ b/src/components/SignInButtons/GoogleSignIn/index.desktop.js @@ -17,7 +17,7 @@ const googleSignInWebRouteForDesktopFlow = `${CONFIG.EXPENSIFY.NEW_EXPENSIFY_URL */ function GoogleSignIn() { return ( - + { window.open(googleSignInWebRouteForDesktopFlow); From 5a60f1eef76f574f06906af84d478afab9a4ffa7 Mon Sep 17 00:00:00 2001 From: Aman Sheikh Date: Thu, 14 Sep 2023 19:00:43 +0530 Subject: [PATCH 2/2] avoid platform/comp specific spacing and use gap instead --- src/styles/styles.js | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/src/styles/styles.js b/src/styles/styles.js index e81e03726c78..ff247009085f 100644 --- a/src/styles/styles.js +++ b/src/styles/styles.js @@ -3676,27 +3676,26 @@ const styles = (theme) => ({ }, loginButtonRow: { - justifyContent: 'center', width: '100%', + gap: 12, ...flex.flexRow, + ...flex.justifyContentCenter, }, loginButtonRowSmallScreen: { - justifyContent: 'center', width: '100%', - marginBottom: 10, + gap: 12, ...flex.flexRow, + ...flex.justifyContentCenter, + marginBottom: 10, }, - appleButtonContainer: { + desktopSignInButtonContainer: { width: 40, height: 40, - marginRight: 20, }, signInIconButton: { - margin: 10, - marginTop: 0, padding: 2, }, @@ -3704,7 +3703,6 @@ const styles = (theme) => ({ colorScheme: 'light', width: 40, height: 40, - marginLeft: 12, alignItems: 'center', overflow: 'hidden', },