From 341cc72b65fca60836c07211ee366c61ec4e02bf Mon Sep 17 00:00:00 2001 From: Jules Rosser Date: Tue, 16 Jul 2024 09:48:12 +0100 Subject: [PATCH 1/3] remove hardcoded todo --- .github/workflows/platformDeploy.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/platformDeploy.yml b/.github/workflows/platformDeploy.yml index 578966726713..7ff52784f259 100644 --- a/.github/workflows/platformDeploy.yml +++ b/.github/workflows/platformDeploy.yml @@ -84,7 +84,7 @@ jobs: if: ${{ !fromJSON(env.SHOULD_DEPLOY_PRODUCTION) }} run: bundle exec fastlane android beta env: - RUBYOPT: '-rostruct' # TODO: Temporary fix until https://github.com/fastlane/fastlane/pull/21950 gets released + RUBYOPT: '-rostruct' MYAPP_UPLOAD_STORE_PASSWORD: ${{ secrets.MYAPP_UPLOAD_STORE_PASSWORD }} MYAPP_UPLOAD_KEY_PASSWORD: ${{ secrets.MYAPP_UPLOAD_KEY_PASSWORD }} @@ -92,7 +92,7 @@ jobs: if: ${{ fromJSON(env.SHOULD_DEPLOY_PRODUCTION) }} run: bundle exec fastlane android production env: - RUBYOPT: '-rostruct' # TODO: Temporary fix until https://github.com/fastlane/fastlane/pull/21950 gets released + RUBYOPT: '-rostruct' VERSION: ${{ env.VERSION_CODE }} - name: Archive Android sourcemaps From 21e9a412d172541289ebec5f72a3ce4cb9bc5c8d Mon Sep 17 00:00:00 2001 From: Jules Rosser Date: Tue, 16 Jul 2024 09:49:01 +0100 Subject: [PATCH 2/3] apply testflight build fix to test builds --- .github/workflows/testBuild.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/testBuild.yml b/.github/workflows/testBuild.yml index 870fc22cd727..aa2ec6b3ed82 100644 --- a/.github/workflows/testBuild.yml +++ b/.github/workflows/testBuild.yml @@ -118,6 +118,7 @@ jobs: id: runFastlaneBetaTest run: bundle exec fastlane android build_internal env: + RUBYOPT: '-rostruct' S3_ACCESS_KEY: ${{ secrets.AWS_ACCESS_KEY_ID }} S3_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }} S3_BUCKET: ad-hoc-expensify-cash From dfd8a52942398271bb96751a0f77fe4f9b2dea72 Mon Sep 17 00:00:00 2001 From: Jules Rosser Date: Tue, 16 Jul 2024 09:54:37 +0100 Subject: [PATCH 3/3] remove newline I accidentally added previously --- .github/workflows/testBuild.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/testBuild.yml b/.github/workflows/testBuild.yml index aa2ec6b3ed82..d092c4469764 100644 --- a/.github/workflows/testBuild.yml +++ b/.github/workflows/testBuild.yml @@ -1,4 +1,3 @@ - name: Build and deploy apps for testing on: