diff --git a/src/libs/ReportUtils.ts b/src/libs/ReportUtils.ts index 4bae619d928e..a8ac92e717cd 100644 --- a/src/libs/ReportUtils.ts +++ b/src/libs/ReportUtils.ts @@ -4112,11 +4112,11 @@ function navigateBackAfterDeleteTransaction(backRoute: Route | undefined, isFrom /** * Go back to the previous page from the edit private page of a given report */ -function goBackFromPrivateNotes(report: OnyxEntry, session: OnyxEntry, backTo?: string) { - if (isEmpty(report) || isEmpty(session) || !session.accountID) { +function goBackFromPrivateNotes(report: OnyxEntry, accountID?: number, backTo?: string) { + if (isEmpty(report) || !accountID) { return; } - const currentUserPrivateNote = report.privateNotes?.[session.accountID]?.note ?? ''; + const currentUserPrivateNote = report.privateNotes?.[accountID]?.note ?? ''; if (isEmpty(currentUserPrivateNote)) { const participantAccountIDs = getParticipantsAccountIDsForDisplay(report); diff --git a/src/pages/PrivateNotes/PrivateNotesEditPage.tsx b/src/pages/PrivateNotes/PrivateNotesEditPage.tsx index ac8eb7f862b6..3be994d1cbcf 100644 --- a/src/pages/PrivateNotes/PrivateNotesEditPage.tsx +++ b/src/pages/PrivateNotes/PrivateNotesEditPage.tsx @@ -46,7 +46,7 @@ type PrivateNotesEditPageProps = WithReportAndPrivateNotesOrNotFoundProps & report: Report; }; -function PrivateNotesEditPage({route, personalDetailsList, report, session}: PrivateNotesEditPageProps) { +function PrivateNotesEditPage({route, personalDetailsList, report, accountID}: PrivateNotesEditPageProps) { const backTo = route.params.backTo; const styles = useThemeStyles(); const {translate} = useLocalize(); @@ -117,7 +117,7 @@ function PrivateNotesEditPage({route, personalDetailsList, report, session}: Pri > ReportUtils.goBackFromPrivateNotes(report, session, backTo)} + onBackButtonPress={() => ReportUtils.goBackFromPrivateNotes(report, accountID, backTo)} shouldShowBackButton onCloseButtonPress={() => Navigation.dismissModal()} /> diff --git a/src/pages/PrivateNotes/PrivateNotesListPage.tsx b/src/pages/PrivateNotes/PrivateNotesListPage.tsx index 424cc3e14683..474075d928f8 100644 --- a/src/pages/PrivateNotes/PrivateNotesListPage.tsx +++ b/src/pages/PrivateNotes/PrivateNotesListPage.tsx @@ -36,7 +36,7 @@ type NoteListItem = { accountID: string; }; -function PrivateNotesListPage({report, session}: PrivateNotesListPageProps) { +function PrivateNotesListPage({report, accountID: sessionAccountID}: PrivateNotesListPageProps) { const route = useRoute>(); const backTo = route.params.backTo; const [personalDetailsList] = useOnyx(ONYXKEYS.PERSONAL_DETAILS_LIST); @@ -76,14 +76,14 @@ function PrivateNotesListPage({report, session}: PrivateNotesListPageProps) { return { reportID: report.reportID, accountID, - title: Number(session?.accountID) === Number(accountID) ? translate('privateNotes.myNote') : personalDetailsList?.[accountID]?.login ?? '', + title: Number(sessionAccountID) === Number(accountID) ? translate('privateNotes.myNote') : personalDetailsList?.[accountID]?.login ?? '', action: () => Navigation.navigate(ROUTES.PRIVATE_NOTES_EDIT.getRoute(report.reportID, accountID, backTo)), brickRoadIndicator: privateNoteBrickRoadIndicator(Number(accountID)), note: privateNote?.note ?? '', - disabled: Number(session?.accountID) !== Number(accountID), + disabled: Number(sessionAccountID) !== Number(accountID), }; }); - }, [report, personalDetailsList, session, translate, backTo]); + }, [report, personalDetailsList, sessionAccountID, translate, backTo]); return ( ; + /** ID of the current user */ + accountID?: number; }; type WithReportAndPrivateNotesOrNotFoundProps = WithReportOrNotFoundProps & WithReportAndPrivateNotesOrNotFoundOnyxProps; @@ -84,7 +82,7 @@ export default function (pageTitle: TranslationPaths) { // eslint-disable-next-line react/jsx-props-no-spreading {...(props as TProps)} ref={ref} - session={session} + accountID={session?.accountID} /> ); }