Skip to content

Commit

Permalink
CR suggestions
Browse files Browse the repository at this point in the history
  • Loading branch information
kirillbilchenko committed Feb 5, 2024
1 parent c6302be commit 1a5f5aa
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions src/components/HeaderPageLayout.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ type HeaderPageLayoutProps = ChildrenProps &
backgroundColor?: string;

/** TestID to apply to the whole section container */
testID?: string;
testID: string;

/** A fixed footer to display at the bottom of the page. */
footer?: ReactNode;
Expand Down Expand Up @@ -76,7 +76,7 @@ function HeaderPageLayout({
shouldEnablePickerAvoiding={false}
includeSafeAreaPaddingBottom={false}
offlineIndicatorStyle={[appBGColor]}
testID={testID || HeaderPageLayout.displayName}
testID={testID}
shouldShowOfflineIndicatorInWideScreen={shouldShowOfflineIndicatorInWideScreen}
>
{({safeAreaPaddingBottomStyle}) => (
Expand Down
2 changes: 1 addition & 1 deletion src/components/IllustratedHeaderPageLayout.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ type IllustratedHeaderPageLayoutProps = HeaderPageLayoutProps & {
overlayContent?: () => ReactNode;

/** TestID to apply to the whole section container */
testID?: string;
testID: string;
};

function IllustratedHeaderPageLayout({backgroundColor, children, illustration, testID, overlayContent, ...rest}: IllustratedHeaderPageLayoutProps) {
Expand Down

0 comments on commit 1a5f5aa

Please sign in to comment.