Skip to content

Commit

Permalink
Merge pull request #44882 from nkdengineer/fix/44801
Browse files Browse the repository at this point in the history
[CP Staging] Fix select all checkbox is not checked when all items are checked

(cherry picked from commit 87f5cdd)
  • Loading branch information
mountiny authored and OSBotify committed Jul 5, 2024
1 parent 8b3bcc6 commit 1bf7319
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
2 changes: 1 addition & 1 deletion src/components/SelectionList/BaseSelectionList.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ function BaseSelectionList<TItem extends ListItem>(
itemLayouts.push({length: fullItemHeight, offset});
offset += fullItemHeight;

if (item.isSelected && !selectedOptions.find((option) => option.text === item.text)) {
if (item.isSelected && !selectedOptions.find((option) => option.keyForList === item.keyForList)) {
selectedOptions.push(item);
}
});
Expand Down
6 changes: 6 additions & 0 deletions src/libs/SearchUtils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,12 @@ function getReportSections(data: OnyxTypes.SearchResults['data'], metadata: Onyx

reportIDToTransactions[reportKey] = {
...value,
<<<<<<< HEAD
=======
keyForList: value.reportID,
from: data.personalDetailsList?.[value.accountID],
to: data.personalDetailsList?.[value.managerID],
>>>>>>> 87f5cdd7 (Merge pull request #44882 from nkdengineer/fix/44801)
transactions,
};
} else if (key.startsWith(ONYXKEYS.COLLECTION.TRANSACTION)) {
Expand Down

0 comments on commit 1bf7319

Please sign in to comment.