Merge pull request #24588 from allroundexperts/fix-24426

feat: update electron builder to generate separate builds
Expensify · Sep 14, 2023 · 207945c · 207945c
2 parents 32f43cf + f629235
commit 207945c
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 6 deletions.
diff --git a/.github/workflows/testBuild.yml b/.github/workflows/testBuild.yml
@@ -354,6 +354,6 @@ jobs:
           IOS: ${{ needs.iOS.result }}
           WEB: ${{ needs.web.result }}
           ANDROID_LINK: ${{steps.get_android_path.outputs.android_path}}
-          DESKTOP_LINK: https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/${{ env.PULL_REQUEST_NUMBER }}/NewExpensify.dmg
+          DESKTOP_LINK: https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/${{ env.PULL_REQUEST_NUMBER }}/NewExpensifyAdHoc.dmg
           IOS_LINK: ${{steps.get_ios_path.outputs.ios_path}}
           WEB_LINK: https://${{ env.PULL_REQUEST_NUMBER }}.pr-testing.expensify.com
diff --git a/config/electronBuilder.config.js b/config/electronBuilder.config.js
@@ -21,6 +21,24 @@ const macIcon = {
     adhoc: './desktop/icon-adhoc.png',
 };
 
+const appIds = {
+    production: 'com.expensifyreactnative.chat',
+    staging: 'com.expensifyreactnative.dev.chat',
+    adhoc: 'com.expensifyreactnative.adhoc.chat',
+};
+
+const productNames = {
+    production: 'New Expensify',
+    staging: 'New Expensify Dev',
+    adhoc: 'New Expensify AdHoc',
+};
+
+const artifactNames = {
+    production: 'NewExpensify.dmg',
+    staging: 'NewExpensifyDev.dmg',
+    adhoc: 'NewExpensifyAdHoc.dmg',
+};
+
 const isCorrectElectronEnv = ['production', 'staging', 'adhoc'].includes(process.env.ELECTRON_ENV);
 
 if (!isCorrectElectronEnv) {
@@ -32,8 +50,8 @@ if (!isCorrectElectronEnv) {
  * It can be used to create local builds of the same, by omitting the `--publish` flag
  */
 module.exports = {
-    appId: 'com.expensifyreactnative.chat',
-    productName: 'New Expensify',
+    appId: appIds[process.env.ELECTRON_ENV],
+    productName: productNames[process.env.ELECTRON_ENV],
     extraMetadata: {
         version,
     },
@@ -46,8 +64,8 @@ module.exports = {
         type: 'distribution',
     },
     dmg: {
-        title: 'New Expensify',
-        artifactName: 'NewExpensify.dmg',
+        title: productNames[process.env.ELECTRON_ENV],
+        artifactName: artifactNames[process.env.ELECTRON_ENV],
         internetEnabled: true,
     },
     publish: [
@@ -65,7 +83,7 @@ module.exports = {
         output: 'desktop-build',
     },
     protocols: {
-        name: 'New Expensify',
+        name: productNames[process.env.ELECTRON_ENV],
         schemes: ['new-expensify'],
     },
 };