Merge pull request #51032 from software-mansion-labs/kicu/50982-searc…

…h-fixes [CP Staging] Fix Search back button on mWeb and report opening in Search
Expensify · Oct 17, 2024 · 20b85d5 · 20b85d5
2 parents 50482b1 + 4ee12c4
commit 20b85d5
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/src/components/Search/SearchRouter/SearchRouterList.tsx b/src/components/Search/SearchRouter/SearchRouterList.tsx
@@ -167,7 +167,7 @@ function SearchRouterList(
             if ('reportID' in item && item?.reportID) {
                 Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(item?.reportID));
             } else if ('login' in item) {
-                Report.navigateToAndOpenReport(item?.login ? [item.login] : []);
+                Report.navigateToAndOpenReport(item.login ? [item.login] : [], false);
             }
         },
         [closeAndClearRouter, onSearchSubmit, currentQuery, updateUserSearchQuery],

diff --git a/src/components/Search/SearchRouter/SearchRouterModal.tsx b/src/components/Search/SearchRouter/SearchRouterModal.tsx
@@ -2,6 +2,7 @@ import React from 'react';
 import FocusTrapForModal from '@components/FocusTrap/FocusTrapForModal';
 import Modal from '@components/Modal';
 import useResponsiveLayout from '@hooks/useResponsiveLayout';
+import * as Browser from '@libs/Browser';
 import CONST from '@src/CONST';
 import SearchRouter from './SearchRouter';
 import {useSearchRouterContext} from './SearchRouterContext';
@@ -15,12 +16,17 @@ function SearchRouterModal() {
     return (
         <Modal
             type={modalType}
-            fullscreen
             isVisible={isSearchRouterDisplayed}
             popoverAnchorPosition={{right: 6, top: 6}}
+            fullscreen
+            shouldHandleNavigationBack={Browser.isMobileChrome()}
             onClose={closeSearchRouter}
         >
-            <FocusTrapForModal active={isSearchRouterDisplayed}>{isSearchRouterDisplayed && <SearchRouter onRouterClose={closeSearchRouter} />}</FocusTrapForModal>
+            {isSearchRouterDisplayed && (
+                <FocusTrapForModal active={isSearchRouterDisplayed}>
+                    <SearchRouter onRouterClose={closeSearchRouter} />
+                </FocusTrapForModal>
+            )}
         </Modal>
     );
 }