Get rid of TODO and replace with note

Expensify · May 11, 2021 · 23b8cea · 23b8cea
1 parent 500e983
commit 23b8cea
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/.github/workflows/finishReleaseCycle.yml b/.github/workflows/finishReleaseCycle.yml
@@ -108,7 +108,7 @@ jobs:
           WORKFLOW: createNewVersion.yml
           INPUTS: '{ "SEMVER_LEVEL": "BUILD" }'
 
-      # TODO: only need to create this tag because of how the GitUtils work
+      # Note: we need to create this tag but not push it, because of how GitUtils.getPullRequestsMergedBetween works
       - name: Tag version
         run: git tag ${{ steps.bumpVersion.outputs.NEW_VERSION }}
 

diff --git a/.github/workflows/lockDeploys.yml b/.github/workflows/lockDeploys.yml
@@ -29,7 +29,7 @@ jobs:
           WORKFLOW: createNewVersion.yml
           INPUTS: '{ "SEMVER_LEVEL": "PATCH" }'
 
-      # TODO: only need to create this tag because of how the GitUtils work
+      # Note: we need to create this tag but not push it, because of how GitUtils.getPullRequestsMergedBetween works
       - name: Tag version
         run: git tag ${{ steps.bumpVersion.outputs.NEW_VERSION }}
 

diff --git a/.github/workflows/preDeploy.yml b/.github/workflows/preDeploy.yml
@@ -76,7 +76,7 @@ jobs:
           WORKFLOW: createNewVersion.yml
           INPUTS: '{ "SEMVER_LEVEL": "BUILD" }'
 
-      # TODO: only need to create this tag because of how the GitUtils work
+      # Note: we need to create this tag but not push it, because of how GitUtils.getPullRequestsMergedBetween works
       - name: Tag version
         run: git tag ${{ steps.bumpVersion.outputs.NEW_VERSION }}