From 27052710e166414a625a2615cfad146a28d7c612 Mon Sep 17 00:00:00 2001 From: Carlos Martins Date: Tue, 18 Jun 2024 11:28:25 -0600 Subject: [PATCH] Merge pull request #43935 from Expensify/revert-43823-fix/sourcemaps-not-uploaded [CP Staging] Revert "fix: CI upload source maps when deploying a new app version" (cherry picked from commit 0dde99da47c38747e983f121bec06a9ac7fc4df7) --- .github/workflows/platformDeploy.yml | 2 +- ios/.xcode.env | 5 ----- workflow_tests/assertions/platformDeployAssertions.ts | 2 +- 3 files changed, 2 insertions(+), 7 deletions(-) diff --git a/.github/workflows/platformDeploy.yml b/.github/workflows/platformDeploy.yml index 20bf0d257a9b..5ceb760a452b 100644 --- a/.github/workflows/platformDeploy.yml +++ b/.github/workflows/platformDeploy.yml @@ -97,7 +97,7 @@ jobs: uses: actions/upload-artifact@v3 with: name: android-sourcemap - path: android/app/build/generated/sourcemaps/react/productionRelease/index.android.bundle.map + path: android/app/build/generated/sourcemaps/react/release/*.map - name: Upload Android version to GitHub artifacts if: ${{ !fromJSON(env.SHOULD_DEPLOY_PRODUCTION) }} diff --git a/ios/.xcode.env b/ios/.xcode.env index 0ef3f59d606a..3d5782c71568 100644 --- a/ios/.xcode.env +++ b/ios/.xcode.env @@ -9,8 +9,3 @@ # For example, to use nvm with brew, add the following line # . "$(brew --prefix nvm)/nvm.sh" --no-use export NODE_BINARY=$(command -v node) - -# Provide a sourcemap path so that in release builds a source map file will be -# created at the specified location. -# (RN's default behaviour on iOS is to skip creating a sourcemap file): -export SOURCEMAP_FILE="$(pwd)/../main.jsbundle.map"; diff --git a/workflow_tests/assertions/platformDeployAssertions.ts b/workflow_tests/assertions/platformDeployAssertions.ts index 03fdcc86ee94..24bb91f001f6 100644 --- a/workflow_tests/assertions/platformDeployAssertions.ts +++ b/workflow_tests/assertions/platformDeployAssertions.ts @@ -64,7 +64,7 @@ function assertAndroidJobExecuted(workflowResult: Step[], didExecute = true, isP steps.push( createStepAssertion('Archive Android sourcemaps', true, null, 'ANDROID', 'Archiving Android sourcemaps', [ {key: 'name', value: 'android-sourcemap'}, - {key: 'path', value: 'android/app/build/generated/sourcemaps/react/productionRelease/index.android.bundle.map'}, + {key: 'path', value: 'android/app/build/generated/sourcemaps/react/release/*.map'}, ]), ); if (!isProduction) {