Separate out shell script linting

.github/workflows/lint.yml

@@ -5,15 +5,15 @@ on:
   pull_request:
     types: [opened, synchronize]
     branches-ignore: [staging, production]
-    paths: ['**.js', '**.ts', '**.tsx', '**.sh']
+    paths: ['**.js', '**.ts', '**.tsx']
 
 jobs:
   lint:
     if: ${{ github.actor != 'OSBotify' || github.event_name == 'workflow_call' }}
     runs-on: ubuntu-latest
     steps:
       - name: Checkout
-        uses: actions/checkout@93ea575cb5d8a053eaa0ac8fa3b40d7e05a33cc8
+        uses: actions/checkout@v3
 
       - name: Setup Node
         uses: Expensify/App/.github/actions/composite/setupNode@main
@@ -23,9 +23,6 @@ jobs:
         env:
           CI: true
 
-      - name: Lint shell scripts with ShellCheck
-        run: npm run shellcheck
-
       - name: Verify there's no Prettier diff
         run: |
           npm run prettier -- --loglevel silent

.github/workflows/shellCheck.yml

@@ -0,0 +1,19 @@
+name: Lint shell code
+
+on:
+  workflow_call:
+  pull_request:
+    types: [opened, synchronize]
+    branches-ignore: [staging, production]
+    paths: ['**.sh']
+
+jobs:
+  lint:
+    if: ${{ github.actor != 'OSBotify' || github.event_name == 'workflow_call' }}
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v3
+
+      - name: Lint shell scripts with ShellCheck
+        run: npm run shellcheck

scripts/shellCheck.sh

@@ -22,7 +22,13 @@ info
 
 ASYNC_PROCESSES=()
 for SHELL_SCRIPT in $SHELL_SCRIPTS; do
-  npx shellcheck -e SC1091 "$SHELL_SCRIPT" &
+  if [[ "$CI" == 'true' ]]; then
+    # ShellCheck is installed by default on GitHub Actions ubuntu runners
+    shellcheck -e SC1091 "$SHELL_SCRIPT" &
+  else
+    # Otherwise shellcheck is used via npx
+    npx shellcheck -e SC1091 "$SHELL_SCRIPT" &
+  fi
   ASYNC_PROCESSES+=($!)
 done