-
Notifications
You must be signed in to change notification settings - Fork 3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge branch 'Expensify:main' into fix/35391
- Loading branch information
Showing
206 changed files
with
4,898 additions
and
2,627 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,64 @@ | ||
| import {parse} from 'csv-parse'; | ||
| import fs from 'fs'; | ||
|
|
||
| const parser = parse(); | ||
|
|
||
| const adjacencyList: Record<string, string[]> = {}; | ||
| const visited: Map<string, boolean> = new Map<string, boolean>(); | ||
| const backEdges: Map<string, boolean> = new Map<string, boolean>(); | ||
|
|
||
| function addEdge(source: string, target: string) { | ||
| if (!adjacencyList[source]) { | ||
| adjacencyList[source] = []; | ||
| } | ||
| adjacencyList[source].push(target); | ||
| } | ||
|
|
||
| function isCyclic(currentNode: string): boolean { | ||
| visited.set(currentNode, true); | ||
| backEdges.set(currentNode, true); | ||
|
|
||
| // Do a depth first search for all the neighbours. If a node is found in backedge, a cycle is detected. | ||
| const neighbours = adjacencyList[currentNode]; | ||
| if (neighbours) { | ||
| for (const node of neighbours) { | ||
| if (!visited.has(node)) { | ||
| if (isCyclic(node)) { | ||
| return true; | ||
| } | ||
| } else if (backEdges.has(node)) { | ||
| return true; | ||
| } | ||
| } | ||
| } | ||
|
|
||
| backEdges.delete(currentNode); | ||
|
|
||
| return false; | ||
| } | ||
|
|
||
| function detectCycle(): boolean { | ||
| for (const [node] of Object.entries(adjacencyList)) { | ||
| if (!visited.has(node)) { | ||
| if (isCyclic(node)) { | ||
| const cycle = Array.from(backEdges.keys()); | ||
| console.log(`Infinite redirect found in the cycle: ${cycle.join(' -> ')} -> ${node}`); | ||
| return true; | ||
| } | ||
| } | ||
| } | ||
| return false; | ||
| } | ||
|
|
||
| fs.createReadStream(`${process.cwd()}/docs/redirects.csv`) | ||
| .pipe(parser) | ||
| .on('data', (row) => { | ||
| // Create a directed graph of sourceURL -> targetURL | ||
| addEdge(row[0], row[1]); | ||
| }) | ||
| .on('end', () => { | ||
| if (detectCycle()) { | ||
| process.exit(1); | ||
| } | ||
| process.exit(0); | ||
| }); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25 changes: 25 additions & 0 deletions
25
...cles/expensify-classic/reports/Assign-report-approvers-to-specific-employees.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| --- | ||
| title: Assign report approvers to specific employees | ||
| description: Create approval hierarchies for reports | ||
| --- | ||
| <div id="expensify-classic" markdown="1"> | ||
|
|
||
| {% include info.html %} | ||
| To assign different approvers for different employees, your workspace must use Advanced Approvals as the report approval workflow. | ||
| {% include end-info.html %} | ||
|
|
||
| Rather than having one approver for all members of the workspace, you can use the Advanced Approvals workflow to assign different report approvers to specific employees. | ||
|
|
||
| To assign a report approver to a specific member of your workspace, | ||
| 1. Hover over Settings, then click **Workspaces**. | ||
| 2. Click the desired workspace name. | ||
| 3. Click the **Members** tab on the left. | ||
| 4. Click **Settings** next to the desired member. | ||
| 5. Click the “Approves to” dropdown and select the desired approver for the member’s reports. | ||
| 6. Click **Save**. | ||
|
|
||
| You can also set | ||
| - Over-limit approval rules that require a secondary approver when a specific member’s report expenses exceed a set limit. | ||
| - Approvers for expenses under a specific tag or category. | ||
|
|
||
| </div> |
20 changes: 20 additions & 0 deletions
20
docs/articles/expensify-classic/reports/Track-report-history.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| --- | ||
| title: Track report history | ||
| description: See the comments and history on a report | ||
| --- | ||
| <div id="expensify-classic" markdown="1"> | ||
|
|
||
| All changes and comments that have been made on a report are tracked at the bottom of the report. | ||
|
|
||
| 1. Click the **Reports** tab. | ||
| 2. Open a report. | ||
| 3. Scroll to the bottom of the report to review the report’s history and comments. | ||
|
|
||
| Additionally, an email notification is sent to the employee when impactful changes are made to the report. For example, if the reimbursable status of an expense is changed, if an expense is approved or denied, or if a comment is added to the report. | ||
|
|
||
| </div> | ||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
Oops, something went wrong.