check for undefined in promiseWhile.ts

Expensify · Apr 8, 2024 · 723014d · 723014d
1 parent ce06355
commit 723014d
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/.github/actions/javascript/awaitStagingDeploys/index.js b/.github/actions/javascript/awaitStagingDeploys/index.js
@@ -12754,6 +12754,9 @@ function promiseDoWhile(condition, action) {
         console.info('[promiseWhile] promiseDoWhile() condition', condition);
         const actionResult = action?.();
         console.info('[promiseWhile] promiseDoWhile() actionResult', actionResult);
+        if (actionResult === undefined) {
+            resolve();
+        }
         actionResult
             ?.then(() => promiseWhile(condition, action))
             .then(() => resolve())

diff --git a/.github/libs/promiseWhile.ts b/.github/libs/promiseWhile.ts
@@ -30,6 +30,11 @@ function promiseDoWhile(condition: () => boolean, action: (() => Promise<void>)
         console.info('[promiseWhile] promiseDoWhile() condition', condition);
         const actionResult = action?.();
         console.info('[promiseWhile] promiseDoWhile() actionResult', actionResult);
+
+        if (actionResult === undefined) {
+            resolve();
+        }
+
         actionResult
             ?.then(() => promiseWhile(condition, action))
             .then(() => resolve())