diff --git a/.github/actions/javascript/markPullRequestsAsDeployed/index.js b/.github/actions/javascript/markPullRequestsAsDeployed/index.js index b3b700d3f8be..c67f38ca1f3e 100644 --- a/.github/actions/javascript/markPullRequestsAsDeployed/index.js +++ b/.github/actions/javascript/markPullRequestsAsDeployed/index.js @@ -12726,7 +12726,7 @@ async function run() { message += `šŸš€`; message += `\n\nplatform | result\n---|---\nšŸ¤– android šŸ¤–|${androidResult}\nšŸ–„ desktop šŸ–„|${desktopResult}`; message += `\nšŸŽ iOS šŸŽ|${iOSResult}\nšŸ•ø web šŸ•ø|${webResult}`; - message += `\nšŸ¤– android HybridApp šŸ¤–|${androidHybridResult}\nšŸŽ iOS HybridApp šŸŽ|${iOSHybridResult}`; + message += `\nšŸ¤–šŸ”„ android HybridApp šŸ¤–šŸ”„|${androidHybridResult}\nšŸŽšŸ”„ iOS HybridApp šŸŽšŸ”„|${iOSHybridResult}`; if (deployVerb === 'Cherry-picked' && !/no ?qa/gi.test(prTitle ?? '')) { // eslint-disable-next-line max-len message += diff --git a/.github/actions/javascript/markPullRequestsAsDeployed/markPullRequestsAsDeployed.ts b/.github/actions/javascript/markPullRequestsAsDeployed/markPullRequestsAsDeployed.ts index f3725a08044f..ba61c31a6bb2 100644 --- a/.github/actions/javascript/markPullRequestsAsDeployed/markPullRequestsAsDeployed.ts +++ b/.github/actions/javascript/markPullRequestsAsDeployed/markPullRequestsAsDeployed.ts @@ -69,7 +69,7 @@ async function run() { message += `šŸš€`; message += `\n\nplatform | result\n---|---\nšŸ¤– android šŸ¤–|${androidResult}\nšŸ–„ desktop šŸ–„|${desktopResult}`; message += `\nšŸŽ iOS šŸŽ|${iOSResult}\nšŸ•ø web šŸ•ø|${webResult}`; - message += `\nšŸ¤– android HybridApp šŸ¤–|${androidHybridResult}\nšŸŽ iOS HybridApp šŸŽ|${iOSHybridResult}`; + message += `\nšŸ¤–šŸ”„ android HybridApp šŸ¤–šŸ”„|${androidHybridResult}\nšŸŽšŸ”„ iOS HybridApp šŸŽšŸ”„|${iOSHybridResult}`; if (deployVerb === 'Cherry-picked' && !/no ?qa/gi.test(prTitle ?? '')) { // eslint-disable-next-line max-len diff --git a/tests/unit/markPullRequestsAsDeployedTest.ts b/tests/unit/markPullRequestsAsDeployedTest.ts index 45fa83a36734..0118f42f6554 100644 --- a/tests/unit/markPullRequestsAsDeployedTest.ts +++ b/tests/unit/markPullRequestsAsDeployedTest.ts @@ -80,7 +80,9 @@ function mockGetInputDefaultImplementation(key: string): boolean | string { case 'DEPLOY_VERSION': return version; case 'IOS': + case 'IOS_HYBRID': case 'ANDROID': + case 'ANDROID_HYBRID': case 'DESKTOP': case 'WEB': return 'success'; @@ -88,7 +90,7 @@ function mockGetInputDefaultImplementation(key: string): boolean | string { case 'NOTE': return ''; default: - throw new Error('Trying to access invalid input'); + throw new Error(`Trying to access invalid input: ${key}`); } } @@ -196,7 +198,9 @@ platform | result šŸ¤– android šŸ¤–|success āœ… šŸ–„ desktop šŸ–„|success āœ… šŸŽ iOS šŸŽ|success āœ… -šŸ•ø web šŸ•ø|success āœ…`, +šŸ•ø web šŸ•ø|success āœ… +šŸ¤–šŸ”„ android HybridApp šŸ¤–šŸ”„|success āœ… +šŸŽšŸ”„ iOS HybridApp šŸŽšŸ”„|success āœ…`, issue_number: PR.issue_number, owner: 'Expensify', repo: 'App', @@ -226,7 +230,9 @@ platform | result šŸ¤– android šŸ¤–|success āœ… šŸ–„ desktop šŸ–„|success āœ… šŸŽ iOS šŸŽ|success āœ… -šŸ•ø web šŸ•ø|success āœ…`, +šŸ•ø web šŸ•ø|success āœ… +šŸ¤–šŸ”„ android HybridApp šŸ¤–šŸ”„|success āœ… +šŸŽšŸ”„ iOS HybridApp šŸŽšŸ”„|success āœ…`, issue_number: PRList[i + 1].issue_number, owner: 'Expensify', repo: 'App', @@ -289,6 +295,8 @@ platform | result šŸ–„ desktop šŸ–„|success āœ… šŸŽ iOS šŸŽ|success āœ… šŸ•ø web šŸ•ø|success āœ… +šŸ¤–šŸ”„ android HybridApp šŸ¤–šŸ”„|success āœ… +šŸŽšŸ”„ iOS HybridApp šŸŽšŸ”„|success āœ… @Expensify/applauseleads please QA this PR and check it off on the [deploy checklist](https://github.com/Expensify/App/issues?q=is%3Aopen+is%3Aissue+label%3AStagingDeployCash) if it passes.`, issue_number: 3, @@ -325,7 +333,9 @@ platform | result šŸ¤– android šŸ¤–|skipped šŸš« šŸ–„ desktop šŸ–„|cancelled šŸ”Ŗ šŸŽ iOS šŸŽ|failed āŒ -šŸ•ø web šŸ•ø|success āœ…`, +šŸ•ø web šŸ•ø|success āœ… +šŸ¤–šŸ”„ android HybridApp šŸ¤–šŸ”„|success āœ… +šŸŽšŸ”„ iOS HybridApp šŸŽšŸ”„|success āœ…`, issue_number: PR.issue_number, owner: 'Expensify', repo: 'App',