feat(Violations): move propTypes into MoneyRequestView

Expensify · Dec 12, 2023 · 7ec9098 · 7ec9098
1 parent e91c965
commit 7ec9098
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 19 deletions.
diff --git a/src/components/ReportActionItem/MoneyRequestView.js b/src/components/ReportActionItem/MoneyRequestView.js
@@ -30,7 +30,6 @@ import * as ReceiptUtils from '@libs/ReceiptUtils';
 import * as ReportActionsUtils from '@libs/ReportActionsUtils';
 import * as ReportUtils from '@libs/ReportUtils';
 import * as TransactionUtils from '@libs/TransactionUtils';
-import {transactionViolationsPropTypes} from '@libs/Violations/propTypes';
 import AnimatedEmptyStateBackground from '@pages/home/report/AnimatedEmptyStateBackground';
 import reportActionPropTypes from '@pages/home/report/reportActionPropTypes';
 import iouReportPropTypes from '@pages/iouReportPropTypes';
@@ -44,6 +43,16 @@ import ONYXKEYS from '@src/ONYXKEYS';
 import ROUTES from '@src/ROUTES';
 import ReportActionItemImage from './ReportActionItemImage';
 
+const violationNames = lodashValues(CONST.VIOLATIONS);
+
+const transactionViolationPropType = PropTypes.shape({
+    type: PropTypes.string.isRequired,
+    name: PropTypes.oneOf(violationNames).isRequired,
+    data: PropTypes.objectOf(PropTypes.string),
+});
+
+const transactionViolationsPropTypes = PropTypes.arrayOf(transactionViolationPropType);
+
 const propTypes = {
     /** The report currently being looked at */
     report: reportPropTypes.isRequired,

diff --git a/src/components/ViolationMessages.tsx b/src/components/ViolationMessages.tsx
@@ -1,7 +1,7 @@
 import React, {useMemo} from 'react';
 import {View} from 'react-native';
 import useLocalize from '@hooks/useLocalize';
-import ViolationsUtils from '@libs/Violations/ViolationsUtils';
+import ViolationsUtils from '@libs/ViolationsUtils';
 import useThemeStyles from '@styles/useThemeStyles';
 import {TransactionViolation} from '@src/types/onyx';
 import Text from './Text';

diff --git a/src/libs/Violations/propTypes.ts b/src/libs/Violations/propTypes.ts
diff --git a/src/libs/Violations/ViolationsUtils.ts → src/libs/ViolationsUtils.ts b/src/libs/Violations/ViolationsUtils.ts → src/libs/ViolationsUtils.ts
@@ -1,9 +1,9 @@
 import reject from 'lodash/reject';
 import Onyx from 'react-native-onyx';
-import {Phrase, PhraseParameters} from '@libs/Localize';
 import {TranslationPaths} from '@src/languages/types';
 import ONYXKEYS from '@src/ONYXKEYS';
 import {PolicyCategories, PolicyTags, Transaction, TransactionViolation} from '@src/types/onyx';
+import {Phrase, PhraseParameters} from './Localize';
 
 const ViolationsUtils = {
     /**

diff --git a/tests/unit/ViolationUtilsTest.js b/tests/unit/ViolationUtilsTest.js
@@ -1,6 +1,6 @@
 import {beforeEach} from '@jest/globals';
 import Onyx from 'react-native-onyx';
-import ViolationsUtils from '@libs/Violations/ViolationsUtils';
+import ViolationsUtils from '@libs/ViolationsUtils';
 import ONYXKEYS from '@src/ONYXKEYS';
 
 const categoryOutOfPolicyViolation = {