Addressed to reviewer comments

Expensify · Feb 4, 2024 · 84317af · 84317af
1 parent 70d6848
commit 84317af
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/src/components/DisplayNames/index.tsx b/src/components/DisplayNames/index.tsx
@@ -18,9 +18,19 @@ function DisplayNames({fullTitle, tooltipEnabled, textStyles, numberOfLines, sho
         );
     }
 
+    if (shouldUseFullTitle) {
+        return (
+            <DisplayNamesWithToolTip
+                shouldUseFullTitle
+                fullTitle={title}
+                textStyles={textStyles}
+                numberOfLines={numberOfLines}
+            />
+        );
+    }
+
     return (
         <DisplayNamesWithToolTip
-            shouldUseFullTitle={shouldUseFullTitle}
             fullTitle={title}
             displayNamesWithTooltips={displayNamesWithTooltips}
             textStyles={textStyles}

diff --git a/src/pages/settings/Report/ReportSettingsPage.tsx b/src/pages/settings/Report/ReportSettingsPage.tsx
@@ -138,7 +138,7 @@ function ReportSettingsPage({report, policies}: ReportSettingsPageProps) {
                                     {translate('workspace.common.workspace')}
                                 </Text>
                                 <DisplayNames
-                                    fullTitle={linkedWorkspace?.name}
+                                    fullTitle={linkedWorkspace.name}
                                     tooltipEnabled
                                     numberOfLines={1}
                                     textStyles={[styles.optionAlternateText, styles.pre]}
@@ -160,7 +160,7 @@ function ReportSettingsPage({report, policies}: ReportSettingsPageProps) {
                                 >
                                     {translate(`newRoomPage.visibilityOptions.${report.visibility}`)}
                                 </Text>
-                                <Text style={[styles.textLabelSupporting, styles.mt1]}>{report.visibility && translate(`newRoomPage.${report.visibility}Description`)}</Text>
+                                <Text style={[styles.textLabelSupporting, styles.mt1]}>{translate(`newRoomPage.${report.visibility}Description`)}</Text>
                             </View>
                         )}
                     </View>