Merge pull request #51547 from daledah/fix/50981

fix: prevent open search when onboarding is not completed
Expensify · Oct 30, 2024 · 8655902 · 8655902
2 parents cfeb1bf + 967eb0f
commit 8655902
Showing 1 changed file with 9 additions and 0 deletions.
diff --git a/src/libs/Navigation/AppNavigator/AuthScreens.tsx b/src/libs/Navigation/AppNavigator/AuthScreens.tsx
@@ -264,6 +264,12 @@ function AuthScreens({session, lastOpenedPublicRoomID, initialLastUpdateIDApplie
         isInitialRender.current = false;
     }
 
+    const isOnboardingCompletedRef = useRef(isOnboardingCompleted);
+
+    useEffect(() => {
+        isOnboardingCompletedRef.current = isOnboardingCompleted;
+    }, [isOnboardingCompleted]);
+
     useEffect(() => {
         const shortcutsOverviewShortcutConfig = CONST.KEYBOARD_SHORTCUTS.SHORTCUTS;
         const searchShortcutConfig = CONST.KEYBOARD_SHORTCUTS.SEARCH;
@@ -362,6 +368,9 @@ function AuthScreens({session, lastOpenedPublicRoomID, initialLastUpdateIDApplie
             searchShortcutConfig.shortcutKey,
             () => {
                 Session.checkIfActionIsAllowed(() => {
+                    if (!isOnboardingCompletedRef.current) {
+                        return;
+                    }
                     toggleSearchRouter();
                 })();
             },