Merge pull request #39037 from software-mansion-labs/@kosmydel/tax-va…

…lue-fix [Taxes] Change max tax value length
Expensify · Mar 28, 2024 · 8976e1e · 8976e1e
2 parents 6c95dfb + 7f2b5dd
commit 8976e1e
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/src/CONST.ts b/src/CONST.ts
@@ -4153,6 +4153,7 @@ const CONST = {
         },
     },
 
+    MAX_TAX_RATE_INTEGER_PLACES: 4,
     MAX_TAX_RATE_DECIMAL_PLACES: 4,
 } as const;
 

diff --git a/src/pages/workspace/taxes/ValuePage.tsx b/src/pages/workspace/taxes/ValuePage.tsx
@@ -91,8 +91,8 @@ function ValuePage({
                                 hideCurrencySymbol
                                 // The default currency uses 2 decimal places, so we substract it
                                 extraDecimals={CONST.MAX_TAX_RATE_DECIMAL_PLACES - 2}
-                                // We increase the amount max length. We have to add 2 places for one digit and comma.
-                                amountMaxLength={CONST.MAX_TAX_RATE_DECIMAL_PLACES + 2}
+                                // We increase the amount max length to support the extra decimals.
+                                amountMaxLength={CONST.MAX_TAX_RATE_DECIMAL_PLACES + CONST.MAX_TAX_RATE_INTEGER_PLACES}
                                 extraSymbol={<Text style={styles.iouAmountText}>%</Text>}
                                 ref={inputCallbackRef}
                             />

diff --git a/src/pages/workspace/taxes/WorkspaceCreateTaxPage.tsx b/src/pages/workspace/taxes/WorkspaceCreateTaxPage.tsx
@@ -108,8 +108,8 @@ function WorkspaceCreateTaxPage({
                                         hideCurrencySymbol
                                         // The default currency uses 2 decimal places, so we substract it
                                         extraDecimals={CONST.MAX_TAX_RATE_DECIMAL_PLACES - 2}
-                                        // We increase the amount max length. We have to add 2 places for one digit and comma.
-                                        amountMaxLength={CONST.MAX_TAX_RATE_DECIMAL_PLACES + 2}
+                                        // We increase the amount max length to support the extra decimals.
+                                        amountMaxLength={CONST.MAX_TAX_RATE_DECIMAL_PLACES + CONST.MAX_TAX_RATE_INTEGER_PLACES}
                                         extraSymbol={<Text style={styles.iouAmountText}>%</Text>}
                                     />
                                 </View>
-Original file line number
+Diff line change
@@ Expand Up / @@ -4153,6 +4153,7 @@ const CONST = { @@
             },
         },
+        MAX_TAX_RATE_INTEGER_PLACES: 4,
         MAX_TAX_RATE_DECIMAL_PLACES: 4,
     } as const;
@@ Expand Down @@