diff --git a/src/components/Modal/BaseModal.js b/src/components/Modal/BaseModal.js index 8de95d9b3b2a..ab9d420f949c 100644 --- a/src/components/Modal/BaseModal.js +++ b/src/components/Modal/BaseModal.js @@ -198,7 +198,6 @@ function BaseModal({ {children} diff --git a/src/components/Pressable/GenericPressable/index.js b/src/components/Pressable/GenericPressable/index.js index 859552e10cf3..65fca85bc324 100644 --- a/src/components/Pressable/GenericPressable/index.js +++ b/src/components/Pressable/GenericPressable/index.js @@ -14,7 +14,8 @@ const WebGenericPressable = forwardRef((props, ref) => ( aria-label={props.accessibilityLabel} aria-labelledby={props.accessibilityLabelledBy} aria-valuenow={props.accessibilityValue} - nativeID={props.nativeID || 'no-drag-area'} + nativeID={props.nativeID} + dataSet={{tag: 'pressable', ...(props.noDragArea && {dragArea: false})}} /> )); diff --git a/src/libs/Navigation/AppNavigator/createResponsiveStackNavigator/ThreePaneView.js b/src/libs/Navigation/AppNavigator/createResponsiveStackNavigator/ThreePaneView.js index 75a5a1f514f7..abdc10180252 100644 --- a/src/libs/Navigation/AppNavigator/createResponsiveStackNavigator/ThreePaneView.js +++ b/src/libs/Navigation/AppNavigator/createResponsiveStackNavigator/ThreePaneView.js @@ -64,12 +64,25 @@ function ThreePaneView(props) { StyleUtils.displayIfTrue(props.state.index === i), ]} > - props.navigation.goBack()} - accessibilityLabel={translate('common.close')} - accessibilityRole={CONST.ACCESSIBILITY_ROLE.BUTTON} - /> + + {/* In the latest Electron version buttons can't be both clickable and draggable. + That's why we added this workaround. Because of two Pressable components on the desktop app + we have 30px draggable ba at the top and the rest of the dimmed area is clickable. On other devices, + everything behaves normally like one big pressable */} + props.navigation.goBack()} + accessibilityLabel={translate('common.close')} + accessibilityRole={CONST.ACCESSIBILITY_ROLE.BUTTON} + /> + props.navigation.goBack()} + accessibilityLabel={translate('common.close')} + accessibilityRole={CONST.ACCESSIBILITY_ROLE.BUTTON} + noDragArea + /> + {props.descriptors[route.key].render()} ); diff --git a/src/pages/home/HeaderView.js b/src/pages/home/HeaderView.js index 696a8f72a73e..74994e4dc9d0 100644 --- a/src/pages/home/HeaderView.js +++ b/src/pages/home/HeaderView.js @@ -138,7 +138,7 @@ function HeaderView(props) { return ( {props.isSmallScreenWidth && ( diff --git a/src/pages/home/sidebar/SidebarLinks.js b/src/pages/home/sidebar/SidebarLinks.js index e54db8b2892d..b81bd5df647a 100644 --- a/src/pages/home/sidebar/SidebarLinks.js +++ b/src/pages/home/sidebar/SidebarLinks.js @@ -161,7 +161,7 @@ class SidebarLinks extends React.PureComponent {
-
+