From 27235736b1772f78e760fa3cbae0e0c8a8983fd4 Mon Sep 17 00:00:00 2001 From: Alex Beaman Date: Wed, 1 Nov 2023 20:46:35 +0200 Subject: [PATCH 1/2] Default to true to make type happy --- src/libs/ReportUtils.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/libs/ReportUtils.js b/src/libs/ReportUtils.js index 21541d558b76..fbcbb21643b0 100644 --- a/src/libs/ReportUtils.js +++ b/src/libs/ReportUtils.js @@ -1267,7 +1267,7 @@ function getDisplayNameForParticipant(accountID, shouldUseShortForm = false, sho * @param {Boolean} shouldFallbackToHidden * @returns {Array} */ -function getDisplayNamesWithTooltips(personalDetailsList, isMultipleParticipantReport, shouldFallbackToHidden) { +function getDisplayNamesWithTooltips(personalDetailsList, isMultipleParticipantReport, shouldFallbackToHidden = true) { return _.chain(personalDetailsList) .map((user) => { const accountID = Number(user.accountID); @@ -1428,7 +1428,7 @@ function requiresAttentionFromCurrentUser(option, parentReportAction = {}) { // Has a child report that is awaiting action (e.g. approve, pay, add bank account) from current user if (option.hasOutstandingChildRequest) { - return true; + return true; } return false; From 254715f2062d5f8e83cd0df0da9216ec7d3f508d Mon Sep 17 00:00:00 2001 From: Alex Beaman Date: Wed, 1 Nov 2023 20:48:41 +0200 Subject: [PATCH 2/2] wtf happened to you --- src/libs/ReportUtils.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libs/ReportUtils.js b/src/libs/ReportUtils.js index fbcbb21643b0..57f8797e6188 100644 --- a/src/libs/ReportUtils.js +++ b/src/libs/ReportUtils.js @@ -1428,7 +1428,7 @@ function requiresAttentionFromCurrentUser(option, parentReportAction = {}) { // Has a child report that is awaiting action (e.g. approve, pay, add bank account) from current user if (option.hasOutstandingChildRequest) { - return true; + return true; } return false;