From 1e876b07e7899e1346fec82bb9c5292bbdd5feac Mon Sep 17 00:00:00 2001 From: Andrew Rosiclair Date: Tue, 9 Jan 2024 12:52:07 -0500 Subject: [PATCH 1/3] add CFBundleVersion and CFBundleShortVersionString --- ios/NotificationServiceExtension/Info.plist | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/ios/NotificationServiceExtension/Info.plist b/ios/NotificationServiceExtension/Info.plist index 57421ebf9b75..ccc7422fe3b4 100644 --- a/ios/NotificationServiceExtension/Info.plist +++ b/ios/NotificationServiceExtension/Info.plist @@ -9,5 +9,9 @@ NSExtensionPrincipalClass $(PRODUCT_MODULE_NAME).NotificationService + CFBundleVersion + 1.4.23.0 + CFBundleShortVersionString + 1.4.23 - + \ No newline at end of file From 16344ae8110ad3439e95c5a7c00a0fb93f33ba71 Mon Sep 17 00:00:00 2001 From: Andrew Rosiclair Date: Tue, 9 Jan 2024 12:57:46 -0500 Subject: [PATCH 2/3] update NotificationServiceExtension version --- .github/libs/nativeVersionUpdater.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/libs/nativeVersionUpdater.js b/.github/libs/nativeVersionUpdater.js index 07d36d823c78..ab129f4eb04a 100644 --- a/.github/libs/nativeVersionUpdater.js +++ b/.github/libs/nativeVersionUpdater.js @@ -10,6 +10,7 @@ const getBuildVersion = require('semver/functions/prerelease'); const BUILD_GRADLE_PATH = process.env.NODE_ENV === 'test' ? path.resolve(__dirname, '../../android/app/build.gradle') : './android/app/build.gradle'; const PLIST_PATH = './ios/NewExpensify/Info.plist'; const PLIST_PATH_TEST = './ios/NewExpensifyTests/Info.plist'; +const PLIST_PATH_NSE = './ios/NotificationServiceExtension/Info.plist'; exports.BUILD_GRADLE_PATH = BUILD_GRADLE_PATH; exports.PLIST_PATH = PLIST_PATH; @@ -81,8 +82,10 @@ exports.updateiOSVersion = function updateiOSVersion(version) { // Update Plists execSync(`/usr/libexec/PlistBuddy -c "Set :CFBundleShortVersionString ${shortVersion}" ${PLIST_PATH}`); execSync(`/usr/libexec/PlistBuddy -c "Set :CFBundleShortVersionString ${shortVersion}" ${PLIST_PATH_TEST}`); + execSync(`/usr/libexec/PlistBuddy -c "Set :CFBundleShortVersionString ${shortVersion}" ${PLIST_PATH_NSE}`); execSync(`/usr/libexec/PlistBuddy -c "Set :CFBundleVersion ${cfVersion}" ${PLIST_PATH}`); execSync(`/usr/libexec/PlistBuddy -c "Set :CFBundleVersion ${cfVersion}" ${PLIST_PATH_TEST}`); + execSync(`/usr/libexec/PlistBuddy -c "Set :CFBundleVersion ${cfVersion}" ${PLIST_PATH_NSE}`); // Return the cfVersion so we can set the NEW_IOS_VERSION in ios.yml return cfVersion; From 497babd2a2e65042eacda68625a37bf2e5a6613e Mon Sep 17 00:00:00 2001 From: Andrew Rosiclair Date: Tue, 9 Jan 2024 14:31:30 -0500 Subject: [PATCH 3/3] build gh actions --- .github/actions/javascript/bumpVersion/index.js | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/actions/javascript/bumpVersion/index.js b/.github/actions/javascript/bumpVersion/index.js index 31a4c6d4246a..1132c137061e 100644 --- a/.github/actions/javascript/bumpVersion/index.js +++ b/.github/actions/javascript/bumpVersion/index.js @@ -19,6 +19,7 @@ const getBuildVersion = __nccwpck_require__(4016); const BUILD_GRADLE_PATH = process.env.NODE_ENV === 'test' ? path.resolve(__dirname, '../../android/app/build.gradle') : './android/app/build.gradle'; const PLIST_PATH = './ios/NewExpensify/Info.plist'; const PLIST_PATH_TEST = './ios/NewExpensifyTests/Info.plist'; +const PLIST_PATH_NSE = './ios/NotificationServiceExtension/Info.plist'; exports.BUILD_GRADLE_PATH = BUILD_GRADLE_PATH; exports.PLIST_PATH = PLIST_PATH; @@ -90,8 +91,10 @@ exports.updateiOSVersion = function updateiOSVersion(version) { // Update Plists execSync(`/usr/libexec/PlistBuddy -c "Set :CFBundleShortVersionString ${shortVersion}" ${PLIST_PATH}`); execSync(`/usr/libexec/PlistBuddy -c "Set :CFBundleShortVersionString ${shortVersion}" ${PLIST_PATH_TEST}`); + execSync(`/usr/libexec/PlistBuddy -c "Set :CFBundleShortVersionString ${shortVersion}" ${PLIST_PATH_NSE}`); execSync(`/usr/libexec/PlistBuddy -c "Set :CFBundleVersion ${cfVersion}" ${PLIST_PATH}`); execSync(`/usr/libexec/PlistBuddy -c "Set :CFBundleVersion ${cfVersion}" ${PLIST_PATH_TEST}`); + execSync(`/usr/libexec/PlistBuddy -c "Set :CFBundleVersion ${cfVersion}" ${PLIST_PATH_NSE}`); // Return the cfVersion so we can set the NEW_IOS_VERSION in ios.yml return cfVersion;