From 9d5deab613c6f005110120a7da04724dcc515fd9 Mon Sep 17 00:00:00 2001 From: Anusha Date: Wed, 16 Oct 2024 21:30:12 +0500 Subject: [PATCH 1/3] remove tooltip --- src/components/FloatingActionButton.tsx | 54 +++++----- .../BottomTabBar.tsx | 100 ++++++++---------- src/pages/home/sidebar/BottomTabAvatar.tsx | 26 +++-- 3 files changed, 84 insertions(+), 96 deletions(-) diff --git a/src/components/FloatingActionButton.tsx b/src/components/FloatingActionButton.tsx index 7c2f5579332a..6728414508d3 100644 --- a/src/components/FloatingActionButton.tsx +++ b/src/components/FloatingActionButton.tsx @@ -99,34 +99,32 @@ function FloatingActionButton({onPress, isActive, accessibilityLabel, role}: Flo }; return ( - - { - fabPressable.current = el ?? null; - if (buttonRef && 'current' in buttonRef) { - buttonRef.current = el ?? null; - } - }} - style={[styles.h100, styles.bottomTabBarItem]} - accessibilityLabel={accessibilityLabel} - onPress={toggleFabAction} - onLongPress={() => {}} - role={role} - shouldUseHapticsOnLongPress={false} - > - - - - - - - + { + fabPressable.current = el ?? null; + if (buttonRef && 'current' in buttonRef) { + buttonRef.current = el ?? null; + } + }} + style={[styles.h100, styles.bottomTabBarItem]} + accessibilityLabel={accessibilityLabel} + onPress={toggleFabAction} + onLongPress={() => {}} + role={role} + shouldUseHapticsOnLongPress={false} + > + + + + + + ); } diff --git a/src/libs/Navigation/AppNavigator/createCustomBottomTabNavigator/BottomTabBar.tsx b/src/libs/Navigation/AppNavigator/createCustomBottomTabNavigator/BottomTabBar.tsx index 16a3e5e098f6..32803ca7579a 100644 --- a/src/libs/Navigation/AppNavigator/createCustomBottomTabNavigator/BottomTabBar.tsx +++ b/src/libs/Navigation/AppNavigator/createCustomBottomTabNavigator/BottomTabBar.tsx @@ -110,61 +110,53 @@ function BottomTabBar({selectedTab}: BottomTabBarProps) { return ( - - + + + {chatTabBrickRoad && } + + + {translate('common.inbox')} + + + + + + + - - - {chatTabBrickRoad && ( - - )} - - - {translate('common.inbox')} - - - - - - - - - - {translate('common.search')} - - - + {translate('common.search')} + + diff --git a/src/pages/home/sidebar/BottomTabAvatar.tsx b/src/pages/home/sidebar/BottomTabAvatar.tsx index fc11e462d7f2..ce921ada6468 100644 --- a/src/pages/home/sidebar/BottomTabAvatar.tsx +++ b/src/pages/home/sidebar/BottomTabAvatar.tsx @@ -68,20 +68,18 @@ function BottomTabAvatar({isCreateMenuOpen = false, isSelected = false}: BottomT } return ( - - - {children} - - {translate('common.settings')} - - - + + {children} + + {translate('common.settings')} + + ); } From efcb39527f02d7e3e9c4cbcb7afdb013a1566a89 Mon Sep 17 00:00:00 2001 From: Anusha Date: Thu, 17 Oct 2024 01:03:40 +0500 Subject: [PATCH 2/3] fix lint --- src/components/FloatingActionButton.tsx | 2 -- .../createCustomBottomTabNavigator/BottomTabBar.tsx | 1 - 2 files changed, 3 deletions(-) diff --git a/src/components/FloatingActionButton.tsx b/src/components/FloatingActionButton.tsx index 6728414508d3..7c17dbf5c6ee 100644 --- a/src/components/FloatingActionButton.tsx +++ b/src/components/FloatingActionButton.tsx @@ -10,7 +10,6 @@ import useTheme from '@hooks/useTheme'; import useThemeStyles from '@hooks/useThemeStyles'; import variables from '@styles/variables'; import {PressableWithoutFeedback} from './Pressable'; -import Tooltip from './Tooltip/PopoverAnchorTooltip'; const AnimatedPath = Animated.createAnimatedComponent(Path); AnimatedPath.displayName = 'AnimatedPath'; @@ -57,7 +56,6 @@ function FloatingActionButton({onPress, isActive, accessibilityLabel, role}: Flo const {success, buttonDefaultBG, textLight, textDark} = useTheme(); const styles = useThemeStyles(); const borderRadius = styles.floatingActionButton.borderRadius; - const {translate} = useLocalize(); const fabPressable = useRef(null); const sharedValue = useSharedValue(isActive ? 1 : 0); const buttonRef = ref; diff --git a/src/libs/Navigation/AppNavigator/createCustomBottomTabNavigator/BottomTabBar.tsx b/src/libs/Navigation/AppNavigator/createCustomBottomTabNavigator/BottomTabBar.tsx index 32803ca7579a..da26d093f3ef 100644 --- a/src/libs/Navigation/AppNavigator/createCustomBottomTabNavigator/BottomTabBar.tsx +++ b/src/libs/Navigation/AppNavigator/createCustomBottomTabNavigator/BottomTabBar.tsx @@ -6,7 +6,6 @@ import * as Expensicons from '@components/Icon/Expensicons'; import {PressableWithFeedback} from '@components/Pressable'; import type {SearchQueryString} from '@components/Search/types'; import Text from '@components/Text'; -import Tooltip from '@components/Tooltip'; import useActiveWorkspace from '@hooks/useActiveWorkspace'; import useLocalize from '@hooks/useLocalize'; import useTheme from '@hooks/useTheme'; From eb6db2e99303bfd9633820273f37b17b2c5e3f9e Mon Sep 17 00:00:00 2001 From: Anusha Date: Thu, 17 Oct 2024 01:07:52 +0500 Subject: [PATCH 3/3] fix lint errors --- src/components/FloatingActionButton.tsx | 1 - src/pages/home/sidebar/BottomTabAvatar.tsx | 1 - 2 files changed, 2 deletions(-) diff --git a/src/components/FloatingActionButton.tsx b/src/components/FloatingActionButton.tsx index 7c17dbf5c6ee..ecf72f89134b 100644 --- a/src/components/FloatingActionButton.tsx +++ b/src/components/FloatingActionButton.tsx @@ -5,7 +5,6 @@ import type {GestureResponderEvent, Role, Text, View} from 'react-native'; import {Platform} from 'react-native'; import Animated, {createAnimatedPropAdapter, Easing, interpolateColor, processColor, useAnimatedProps, useAnimatedStyle, useSharedValue, withTiming} from 'react-native-reanimated'; import Svg, {Path} from 'react-native-svg'; -import useLocalize from '@hooks/useLocalize'; import useTheme from '@hooks/useTheme'; import useThemeStyles from '@hooks/useThemeStyles'; import variables from '@styles/variables'; diff --git a/src/pages/home/sidebar/BottomTabAvatar.tsx b/src/pages/home/sidebar/BottomTabAvatar.tsx index ce921ada6468..32aa1d455b5e 100644 --- a/src/pages/home/sidebar/BottomTabAvatar.tsx +++ b/src/pages/home/sidebar/BottomTabAvatar.tsx @@ -2,7 +2,6 @@ import React, {useCallback} from 'react'; import {useOnyx} from 'react-native-onyx'; import {PressableWithFeedback} from '@components/Pressable'; import Text from '@components/Text'; -import Tooltip from '@components/Tooltip'; import useCurrentUserPersonalDetails from '@hooks/useCurrentUserPersonalDetails'; import useLocalize from '@hooks/useLocalize'; import useThemeStyles from '@hooks/useThemeStyles';