refactor props

Expensify · Sep 15, 2023 · b81a159 · b81a159
1 parent 164b129
commit b81a159
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 14 deletions.
diff --git a/src/pages/EditRequestReceiptPage.js b/src/pages/EditRequestReceiptPage.js
@@ -40,7 +40,6 @@ function EditRequestReceiptPage({route, transactionID}) {
                 <ReceiptSelector
                     route={route}
                     transactionID={transactionID}
-                    isReplacingReceipt
                 />
             </DragAndDropProvider>
         </ScreenWrapper>

diff --git a/src/pages/iou/ReceiptSelector/index.js b/src/pages/iou/ReceiptSelector/index.js
@@ -49,9 +49,6 @@ const propTypes = {
     /** Holds data related to Money Request view state, rather than the underlying Money Request data. */
     iou: iouPropTypes,
 
-    /** Whether the user is replacing the receipt */
-    isReplacingReceipt: PropTypes.bool,
-
     /** The id of the transaction we're editing */
     transactionID: PropTypes.string,
 };
@@ -64,7 +61,6 @@ const defaultProps = {
     },
     report: {},
     iou: iouDefaultProps,
-    isReplacingReceipt: false,
     transactionID: '',
 };
 
@@ -93,7 +89,7 @@ function ReceiptSelector(props) {
         const filePath = URL.createObjectURL(file);
         IOU.setMoneyRequestReceipt(filePath, file.name);
 
-        if (props.isReplacingReceipt) {
+        if (props.transactionID) {
             IOU.replaceReceipt(props.transactionID, file, filePath);
             Navigation.dismissModal();
             return;

diff --git a/src/pages/iou/ReceiptSelector/index.native.js b/src/pages/iou/ReceiptSelector/index.native.js
@@ -44,17 +44,13 @@ const propTypes = {
     /** Holds data related to Money Request view state, rather than the underlying Money Request data. */
     iou: iouPropTypes,
 
-    /** Whether the user is replacing the receipt */
-    isReplacingReceipt: PropTypes.bool,
-
     /** The id of the transaction we're editing */
     transactionID: PropTypes.string,
 };
 
 const defaultProps = {
     report: {},
     iou: iouDefaultProps,
-    isReplacingReceipt: false,
     transactionID: '',
 };
 
@@ -83,7 +79,7 @@ function getImagePickerOptions(type) {
     };
 }
 
-function ReceiptSelector({route, report, iou, isReplacingReceipt, transactionID}) {
+function ReceiptSelector({route, report, iou, transactionID}) {
     const devices = useCameraDevices('wide-angle-camera');
     const device = devices.back;
 
@@ -206,7 +202,7 @@ function ReceiptSelector({route, report, iou, isReplacingReceipt, transactionID}
             .then((photo) => {
                 IOU.setMoneyRequestReceipt(`file://${photo.path}`, photo.path);
 
-                if (isReplacingReceipt) {
+                if (transactionID) {
                     IOU.replaceReceipt(transactionID, photo, `file://${photo.path}`);
                     Navigation.dismissModal();
                     return;
@@ -218,7 +214,7 @@ function ReceiptSelector({route, report, iou, isReplacingReceipt, transactionID}
                 showCameraAlert();
                 Log.warn('Error taking photo', error);
             });
-    }, [flash, iouType, iou, report, reportID, translate, transactionID, isReplacingReceipt]);
+    }, [flash, iouType, iou, report, reportID, translate, transactionID]);
 
     CameraPermission.getCameraPermissionStatus().then((permissionStatus) => {
         setPermissions(permissionStatus);
@@ -278,7 +274,7 @@ function ReceiptSelector({route, report, iou, isReplacingReceipt, transactionID}
                             .then((receiptImage) => {
                                 IOU.setMoneyRequestReceipt(receiptImage[0].uri, receiptImage[0].fileName);
 
-                                if (isReplacingReceipt) {
+                                if (transactionID) {
                                     IOU.replaceReceipt(transactionID, receiptImage, receiptImage[0].uri);
                                     Navigation.dismissModal();
                                     return;