Merge pull request #34884 from allroundexperts/fix-34865

feat: disable enforced report fields
Expensify · Jan 23, 2024 · c060897 · c060897
2 parents 332a876 + 0485bec
commit c060897
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 1 deletion.
diff --git a/src/CONST.ts b/src/CONST.ts
@@ -3131,6 +3131,7 @@ const CONST = {
     },
 
     MINI_CONTEXT_MENU_MAX_ITEMS: 4,
+    REPORT_FIELD_TITLE_FIELD_ID: 'text_title',
 } as const;
 
 type Country = keyof typeof CONST.ALL_COUNTRIES;

diff --git a/src/components/ReportActionItem/MoneyReportView.tsx b/src/components/ReportActionItem/MoneyReportView.tsx
@@ -77,7 +77,7 @@ function MoneyReportView({report, policyReportFields, shouldShowHorizontalRule}:
                                     title={title}
                                     onPress={() => Navigation.navigate(ROUTES.EDIT_REPORT_FIELD_REQUEST.getRoute(report.reportID, report.policyID ?? '', reportField.fieldID))}
                                     shouldShowRightIcon
-                                    disabled={false}
+                                    disabled={ReportUtils.isReportFieldOfTypeTitle(reportField)}
                                     wrapperStyle={[styles.pv2, styles.taskDescriptionMenuItem]}
                                     shouldGreyOutWhenDisabled={false}
                                     numberOfLinesTitle={0}

diff --git a/src/libs/ReportUtils.ts b/src/libs/ReportUtils.ts
@@ -4525,6 +4525,13 @@ function getReportFieldTitle(report: OnyxEntry<Report>, reportField: PolicyRepor
     });
 }
 
+/**
+ * Given a report field, check if the field is for the report title.
+ */
+function isReportFieldOfTypeTitle(reportField: PolicyReportField): boolean {
+    return reportField.type === 'formula' && reportField.fieldID === CONST.REPORT_FIELD_TITLE_FIELD_ID;
+}
+
 /**
  * Checks if thread replies should be displayed
  */
@@ -4740,6 +4747,7 @@ export {
     shouldDisableThread,
     doesReportBelongToWorkspace,
     getChildReportNotificationPreference,
+    isReportFieldOfTypeTitle,
 };
 
 export type {